The default bug view has changed. See this FAQ.

In the Style Editor, remove the stylesheet filter

VERIFIED FIXED in Firefox 11

Status

()

Firefox
Developer Tools: Style Editor
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: paul, Assigned: cedricv)

Tracking

Trunk
Firefox 12
x86
All
Points:
---

Firefox Tracking Flags

(firefox11 verified, firefox12 verified)

Details

(Whiteboard: [qa!])

Attachments

(2 attachments, 6 obsolete attachments)

(Reporter)

Description

5 years ago
This is not really useful, and can be a bit confusing.
(Assignee)

Comment 1

5 years ago
As discussed, we'll change the behavior to a more useful "Find in all style sheets" (bug 719409)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 2

5 years ago
Bug 719409 won't be fixed for Firefox 11. To avoid confusion, I think we should remove this feature in Firefox 11.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(Reporter)

Comment 3

5 years ago
Created attachment 590724 [details] [diff] [review]
patch v1
(Reporter)

Comment 4

5 years ago
The logic behind this deletion is:
- the filter-by-name feature is not useful
- we want to replace the behavior of the search field from filter-by-name to filter-by-content
- this won't happen for Firefox 11 or Firefox 12
- we don't want people to get used to a feature that will be removed and replaced by something that "look" the same but won't do the same thing
(Reporter)

Comment 5

5 years ago
Created attachment 590726 [details] [diff] [review]
patch v1.1
(Reporter)

Updated

5 years ago
Attachment #590724 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Attachment #590726 - Flags: feedback?(cedricv)
(Reporter)

Comment 6

5 years ago
Comment on attachment 590726 [details] [diff] [review]
patch v1.1

Asking dcamp to review to make sure we can land that asap.
But we still need a f+ from Cedric.
Attachment #590726 - Flags: review?(dcamp)

Updated

5 years ago
Attachment #590726 - Flags: review?(dcamp) → review+
(Assignee)

Comment 7

5 years ago
Comment on attachment 590726 [details] [diff] [review]
patch v1.1

f- because I actually want to say "f+ but...

...ideally, we could still keep the "search-on-type" feature even so we remove it the visible searchbox for Fx11 :)
Attachment #590726 - Flags: feedback?(cedricv) → feedback-
(Reporter)

Comment 8

5 years ago
I don't think we want to keep dead code. You can re-introduce this code if needed.
(Assignee)

Comment 9

5 years ago
(In reply to Paul Rouget [:paul] from comment #8)
> I don't think we want to keep dead code. You can re-introduce this code if
> needed.

I meant I think we should keep the logic AND the "search-on-type" UI (you can try it, eg., when the Style Editor is in narrow in vertical side bar)
(Assignee)

Comment 10

5 years ago
Comment on attachment 590726 [details] [diff] [review]
patch v1.1

So as discussed on IRC, we'll rather improve the search-on-type filter and land it together with the new global search box later.
Attachment #590726 - Flags: feedback- → feedback+
(Reporter)

Comment 11

5 years ago
So I run into an issue. With this patch, we can actually resize the right panel in a way that the buttons get hidden.

If, in the toolbar, I add a <xul:textbox flex="1"> (after the button, or between the buttons), the toolbar can't get over-resized.

I really don't understand what is going on. I need some help here.
(Reporter)

Comment 12

5 years ago
Created attachment 591144 [details]
screencast (see comment 11)
(Assignee)

Comment 13

5 years ago
Created attachment 591391 [details] [diff] [review]
patch v2 - rebased against tip and micro fixes

Paul, I had a look at it... tried few things but no idea what is going on with that resizer :/
Anyways I rebased the patch to apply against tip.
Attachment #590726 - Attachment is obsolete: true
(Assignee)

Comment 14

5 years ago
Created attachment 591392 [details] [diff] [review]
patch v2 - remove more unused entities from dtd
Attachment #591391 - Attachment is obsolete: true
(Assignee)

Comment 15

5 years ago
Created attachment 591394 [details] [diff] [review]
patch v3 - resizer bug fixed (!?)

Seems to work now. Yay!
Attachment #591392 - Attachment is obsolete: true
Attachment #591394 - Flags: review?(paul)
(Assignee)

Comment 16

5 years ago
Created attachment 591395 [details] [diff] [review]
patch v3.1 - better id naming
Attachment #591394 - Attachment is obsolete: true
Attachment #591394 - Flags: review?(paul)
Attachment #591395 - Flags: review?(paul)
(Reporter)

Comment 17

5 years ago
Comment on attachment 591395 [details] [diff] [review]
patch v3.1 - better id naming

Thank you Cedric. Can I just ask you to find a better "id" for splitview-nav-container? It's a little confusing to get the same className and Id.
Attachment #591395 - Flags: review?(paul) → review+
(Assignee)

Comment 18

5 years ago
Created attachment 591407 [details] [diff] [review]
patch v3.2 - id name change + move persist attribute as well
Attachment #591395 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Attachment #591407 - Flags: review+
(Reporter)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Reporter)

Updated

5 years ago
Assignee: nobody → cedricv
(Reporter)

Comment 19

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/ffaed1950e3b
status-firefox12: --- → fixed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
(Reporter)

Comment 20

5 years ago
I will a? this patch once in central.
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team][addToFirefox11]
https://hg.mozilla.org/mozilla-central/rev/ffaed1950e3b
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][addToFirefox11] → [addToFirefox11]
Target Milestone: --- → Firefox 12
Comment on attachment 591407 [details] [diff] [review]
patch v3.2 - id name change + move persist attribute as well

[Approval Request Comment]
Regression caused by (bug #): Not a regression. New feature.
User impact if declined: Confusing Feature will Confuse Users, some window repositioning behavior may not work as expected.
Testing completed (on m-c, etc.): on m-c, local testing.
Risk to taking this patch (and alternatives if risky): negligible. Patch removes more code than adds. Clean!
Attachment #591407 - Flags: approval-mozilla-aurora?
Comment on attachment 591407 [details] [diff] [review]
patch v3.2 - id name change + move persist attribute as well

[Triage Comment]
It's difficult to argue with the removal of functionality in a new feature for the sake of minimizing user confusion. Approved for Aurora.
Attachment #591407 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/a8d8390ebb52
status-firefox11: --- → fixed
(Reporter)

Updated

5 years ago
Whiteboard: [addToFirefox11]
Whiteboard: [qa+]
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0

Verified using Firefox 11 beta 1 on Windows 7, Ubuntu 11.10 and Mac OS X 10.6 that the stylesheet filter has been removed from the Style Editor.
status-firefox11: fixed → verified
Whiteboard: [qa+] → [qa+][qa!:11]
Verified as fixed on Firefox 12 beta 2 - the stylesheet filter has been removed from the Style Editor.

Verified on Windows 7, Ubuntu 11.10 and Mac OS X 10.6.
Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0

Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
status-firefox12: fixed → verified
Whiteboard: [qa+][qa!:11] → [qa!]
You need to log in before you can comment on or make changes to this bug.