Labels should be right aligned in bug view

RESOLVED FIXED

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: BYK, Assigned: dkl)

Tracking

Production

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

7 years ago
The labels' alignment in the bug view is to the left and this it hard to read and quickly understand the information presented. I propose the following change in the global.css file

.field_label {
    text-align: right;
}

Please note that this change introduces a minor visual glitch with tags which should be addressed.
(Reporter)

Updated

7 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Updated

7 years ago
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Assignee)

Comment 1

7 years ago
This basically just involved removing the override in skins/custom/global.css 

.field_label {
     text-align: left;
}

This was added by Gerv during the migration of BMO from 3.6 to 4.0 back end of 2010.

I will make a patch with this removal as well as a patch to fix the flags section of show_bug.cgi which looks bad when this is removed.

dkl
(Assignee)

Comment 2

7 years ago
Created attachment 586755 [details] [diff] [review]
Patch to align field labels to the right in show_bug.cgi (v1)

Patch that reverts the BMO customization that aligns the field lables to the left. This brings it back inline with upstream and looks better IMO. Also once I made the change, I needed to change how the flags section was rendered to make it look correct to take a look at that as well. 

dkl
Attachment #586755 - Flags: review?(glob)
Comment on attachment 586755 [details] [diff] [review]
Patch to align field labels to the right in show_bug.cgi (v1)

i much prefer this layout, however this leaves a lot of unused whitespace in the leftmost column.  this is because the main bugs table has a width of 100% and all columns are expanded to fill the width of the window.
Attachment #586755 - Flags: review?(glob) → review-
(Assignee)

Comment 4

7 years ago
Created attachment 587425 [details] [diff] [review]
Patch to align field labels to the right in show_bug.cgi (v2)

New patch the removes the leftmost whitespace also removes bz_column_spacer as it is not really necessary and just pushes the right column over more than it is already.

dkl
Attachment #586755 - Attachment is obsolete: true
Attachment #587425 - Flags: review?(glob)
Created attachment 587601 [details] [diff] [review]
alternative approach

what do you think of this approach?
(Assignee)

Comment 6

7 years ago
Created attachment 587705 [details] [diff] [review]
Patch to align field labels to the right in show_bug.cgi (v3)

Thats looks better to me as well. Here is a new patch incorporating your style change with my other changes.

dkl
Attachment #587425 - Attachment is obsolete: true
Attachment #587425 - Flags: review?(glob)
Attachment #587705 - Flags: review?(glob)
Comment on attachment 587705 [details] [diff] [review]
Patch to align field labels to the right in show_bug.cgi (v3)

i think it looks more balanced with the bz_column_spacer still in place, but i'm not going to r- because of that.

r=glob :)
Attachment #587705 - Flags: review?(glob) → review+
(Assignee)

Comment 8

7 years ago
Added back the bz_column_spacer. Committed and will be in the next code push.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified skins/custom/global.css
modified skins/custom/show_bug.css
modified template/en/default/bug/edit.html.tmpl
Committed revision 8016.

dkl
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
i've pushed a minor tweak to keep the 50/50 layout of the columns:

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified skins/custom/show_bug.css
Committed revision 8022.
You need to log in before you can comment on or make changes to this bug.