devicemanager processExist may report false positives

RESOLVED FIXED in mozilla12

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

unspecified
mozilla12
x86
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

devicemanager.processExist(appname) searches the list of running processes for a match to the regular expression (roughly) .*<appname>.*

This can cause confusion if the specified appname is short and/or generic. For instance, dm.processExist("am") returns pid 2764 if this process exists:

['2764', '/system/bin/gpsd/glgps_samsungJupiter', 'system']
                                  ^^
Blocks: 715309
Attachment #586578 - Attachment is obsolete: true
Attachment #586578 - Flags: review?(jmaher)
Attachment #586610 - Flags: review?(jmaher)
I found that the same code is in devicemanagerSUT and causes the same problem for me when running mochitest-remote via SUT -- fixed in both places now.
Comment on attachment 586610 [details] [diff] [review]
patch to match

Review of attachment 586610 [details] [diff] [review]:
-----------------------------------------------------------------

looks great, thanks!
Attachment #586610 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/96e27b40144f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.