Last Comment Bug 716168 - Remove browser/components/wintaskbar/* leftovers from bug 699575
: Remove browser/components/wintaskbar/* leftovers from bug 699575
Status: RESOLVED FIXED
[qa-]
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Firefox 12
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on: 699575
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-06 18:11 PST by Ed Morley [:emorley]
Modified: 2012-01-10 01:59 PST (History)
2 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (4.66 KB, patch)
2012-01-06 18:14 PST, Ed Morley [:emorley]
gavin.sharp: review+
Details | Diff | Review
Patch v2 (6.76 KB, patch)
2012-01-06 19:35 PST, Ed Morley [:emorley]
no flags Details | Diff | Review

Description Ed Morley [:emorley] 2012-01-06 18:11:40 PST
Bug 699575 moved the files in browser/components/wintaskbar/ to browser/modules/ and made the wintaskbar directory NPTOB (https://hg.mozilla.org/mozilla-central/rev/e27edbae265e). The two remaining makefiles are unused.
Comment 1 Ed Morley [:emorley] 2012-01-06 18:14:43 PST
Created attachment 586630 [details] [diff] [review]
Patch v1

Removes the two remaining makefiles, which are NPOTB (https://hg.mozilla.org/mozilla-central/rev/e27edbae265e#l5.13). The makefiles.sh entries have already been removed (https://hg.mozilla.org/mozilla-central/rev/e27edbae265e#l6.27).
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-01-06 18:17:52 PST
Comment on attachment 586630 [details] [diff] [review]
Patch v1

Hrm, I'm sure I'd deleted this directory - I blame rebase.

Not really related, but could you update the references to wintaskbar in test_webgl_conformance_test_suite.html while you're at it?

Thanks!
Comment 3 Ed Morley [:emorley] 2012-01-06 19:35:39 PST
Created attachment 586636 [details] [diff] [review]
Patch v2

Sure :-)
Comment 5 Marco Bonardo [::mak] 2012-01-10 01:59:11 PST
https://hg.mozilla.org/mozilla-central/rev/212eea4c8b3b

Note You need to log in before you can comment on or make changes to this bug.