716235 - pymake should handle environment variables with a recursive flavor

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Quentin Raynaud]

Attachment: env_recursive.sh

User Agent: Mozilla/5.0 (Ubuntu; X11; Linux x86_64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111228084940

Steps to reproduce:

I'm working on using pymake by default for the Instantbird's build system. One of the issue we encountered is that environment variables loaded in pymake are not loaded using the correct flavor.

The attached script, invoked using comands to execute gmake & pymake as arguments (e.g: env_recursive.sh make "python -OO build/pymake/make.py") shows the difference between the two.


Actual results:

Using gmake, something like:
VAR1="$(VAR2) 4" VAR2="1 2 3" make target
will work as expected $(VAR1) will be expended into "1 2 3 4" while with pymake it will put an error on each line using it telling us "VAR2" is not found.


Expected results:

Everything should be expended recursively.

Comment 1

[Quentin Raynaud]

Attachment: Correct the behaviour

Here is a patch that should correct this behaviour that I believe incorrect.

Comment 2

[Benjamin Smedberg]

Before I can accept this it will need a test added to the pymake testsuite.

Comment 3

[Benjamin Smedberg]

Comment on attachment 586670 [details] [diff] [review]
Correct the behaviour

Also, it would be better to write the patch against the pymake repository, which we import into mozilla-central: http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake

Comment 4

[Chris Cooper [:coop] (he/him)]

Mass close of pymake-related bugs.