Closed Bug 716235 Opened 9 years ago Closed 3 years ago

pymake should handle environment variables with a recursive flavor

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bugzilla, Unassigned)

References

Details

Attachments

(2 files)

Attached file env_recursive.sh
User Agent: Mozilla/5.0 (Ubuntu; X11; Linux x86_64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111228084940

Steps to reproduce:

I'm working on using pymake by default for the Instantbird's build system. One of the issue we encountered is that environment variables loaded in pymake are not loaded using the correct flavor.

The attached script, invoked using comands to execute gmake & pymake as arguments (e.g: env_recursive.sh make "python -OO build/pymake/make.py") shows the difference between the two.


Actual results:

Using gmake, something like:
VAR1="$(VAR2) 4" VAR2="1 2 3" make target
will work as expected $(VAR1) will be expended into "1 2 3 4" while with pymake it will put an error on each line using it telling us "VAR2" is not found.


Expected results:

Everything should be expended recursively.
Here is a patch that should correct this behaviour that I believe incorrect.
Attachment #586670 - Flags: review?
Attachment #586670 - Flags: review? → review?(khuey)
Before I can accept this it will need a test added to the pymake testsuite.
Comment on attachment 586670 [details] [diff] [review]
Correct the behaviour

Also, it would be better to write the patch against the pymake repository, which we import into mozilla-central: http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake
Attachment #586670 - Flags: review?(khuey) → review-
Status: UNCONFIRMED → NEW
Ever confirmed: true
Mass close of pymake-related bugs.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.