Meaningless boolean flag parameters to methods on nsISelectionController

NEW
Unassigned

Status

()

--
minor
7 years ago
22 days ago

People

(Reporter: neil, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
nsISelectionController has the following scrolling and movement methods:
CharacterMove	ScrollCharacter
CompleteMove	CompleteScroll
PageMove	ScrollPage
LineMove	ScrollLine
WordMove
IntraLineMove
The scrolling methods currently take a boolean parameter which indicates the direction of the scroll. The movement methods currently take two boolean parameters, one which indicates the direction of the movement and the other indicates whether to extend or collapse the selection.
(Reporter)

Comment 1

7 years ago
Created attachment 586859 [details] [diff] [review]
Untested patch

I replaced those methods with three: Scroll, Collapse and Extend, which accept one of 12 motion codes. There is also part of an idea to make Ctrl+Left/Right scroll to the beginning/end of the line, but the code has been disabled.

It does compile, at least. I don't know whether my substitutions are correct, or whether it passes any tests.

Updated

27 days ago
Product: Core → Core Graveyard
(Assignee)

Updated

22 days ago
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.