716526 - CMD+W opens new tab instead of closing it

Status: RESOLVED DUPLICATE of bug 380637

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Grimeton]

Attachment: Screenshot

Hi,

while trying to download "GIMP on OS X" I found some kind of a bug. I browsed to the "GOSX" webpage (check the screenshot attached) and started the download.

The link was opened in a new tab to start the download from sourceforge.net.

After the download started, I closed the "sourceforge-tab" by pressing cmd+w on my mac keyboard. It was closed and I was back at the "GIMP on OS X"-tab. There I hit cmd+w again and instead of closing this tab, it opened the donwload link again in a new tab.

On the screenshot you can see the selected link. 

Actually I'm running a beta: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0) Gecko/20120105 Firefox/10.0 SeaMonkey/2.7

If you have any questions contact me.

Btw: If you try to add a bug to bugzilla in the guided mode, the list of components is empty and unusable.

KR,

Grimeton

Comment 1

[Justin Wood (:Callek)]

stefan/karsten can one of you investigate c#0 and follow up with reporter if more info is needed. This is certainly a bad regression if its repeatable on mac.

If it does regress, lets mark it tracking and find a regression-range/patch ASAP

Comment 2

[Philip Chee]

Grimeton, is this bug repeatable consistently or is this a one off? Does this also happen in SeaMonkey safemode? Go Help->Restart with Addons Disabled.

Comment 3

[Grimeton]

Philip,

yes it does. I restarted Seamonkey in "safe mode" and it still tries to open the new tab. But now Seamonkey blocks the tab to be opened. In safe and "non-safe"-mode.

Added another screenshot. 

I'll try to reproduce this on my MBP when I'm at home.

KR,

Grimeton

Comment 4

[Grimeton]

Attachment: Screenshot of blocking the new tab

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 587003 [details]
Screenshot of blocking the new tab

This error message sounds like the website is *trying* to open a new window when you close the tab. Does it happen with other (generic) websites [like seamonkey-project.org]

Comment 6

[Grimeton]

Hi,

i did a bit of testing:

Seamonkey 2.7b3 -> opens tab
Mozarella Firefox ( Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0.1) Gecko/20100101 Firefox/9.0.1) -> opens tab
Opera (11.60, Build 1185) -> closes tab
Safari Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/534.52.7 (KHTML, like Gecko) Version/5.1.2 Safari/534.52.7 -> closes tab

Installing Internet Explorer on OS X is a bit tricky atm...

But as two of four browsers, using a different engine, are closing the tab I suspect this to be a bug somewhere "deeper". I checked the source of the page and found some onkeypress events that should open the download tab on keypress.

<a onclick="window.open(this.href); return false;" title="http://downloads.sourceforge.net/gimponosx/GIMP-2.6.11-Snow-Leopard.dmg?use_mirror=" href="http://downloads.sourceforge.net/gimponosx/GIMP-2.6.11-Snow-Leopard.dmg?use_mirror=" onkeypress="window.open(this.href); return false;">GIMP 2.6.11 for Snow Leopard</a>

IMHO that should not happen if the tab is to be closed, as it doesn't when closing the tab by clicking the "x".


KR,

Grimeton

Comment 7

[Stefan [:stefanh]]

I can reproduce this on my netbook with Mozilla/5.0 (Ubuntu; X11; Linux x86_64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1, so it's not a mac-specific problem.

Whatever key you press after you have clicked the link trigger the onkeypress handler. I haven't investigated further, but it seems a bit weird to have it there, I also wonder why it doesn't happen in non-Gecko browsers?

Comment 8

[Stefan [:stefanh]]

This needs a new component (my best guess is core:event handling). I think the question is whether our behavior is correct or not (comment #6 indicates that our behavior is unique).

Comment 9

[Boris Zbarsky [:bzbarsky]]

Isn't this a duplicate of bug 380637?

Comment 10

[Stefan [:stefanh]]

(In reply to Boris Zbarsky (:bz) from comment #9)
> Isn't this a duplicate of bug 380637?

True, thanks Boris.