716582 - Send quit-application in uriloader/exthandler/tests/unit_ipc/test_encoding.js

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Send quit-application in uriloader/exthandler/tests/unit_ipc/test_encoding.js

https://tbpl.mozilla.org/?tree=Try&rev=afd596aad2ef

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 587028 [details] [diff] [review]
Send quit-application in uriloader/exthandler/tests/unit_ipc/test_encoding.js

Review of attachment 587028 [details] [diff] [review]:
-----------------------------------------------------------------

::: uriloader/exthandler/tests/unit_ipc/test_encoding.js
@@ +6,5 @@
>  Cu.import("resource://gre/modules/Services.jsm");
>  
> +do_register_cleanup(function() {
> +  Services.obs.notifyObservers(null, "quit-application", null);
> +});

the harness fires profile close notifications as the first shutdown function, so doing this would notify quit-application after them, that is wrong.

This is actually a limitation in the harness header that internally uses the same do_register_cleanup call, should probably handle that differently to always keep it as the last task. See http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/head.js#744

So, could you file a bug and figure out how to ensure that cleanup task firing profile notifications is executed last?

That said, now that bug 713172 landed the DM shutdown at profile-before-change, so I think this bug is now wfm

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Yes, that patch fixed this bug too.

Comment 4

[shubham sharma]

To get the simplest deal, you'll look for the parts online, check the corporate review and plow ahead within the process of shopping for auto parts. Once you've got selected the web site, you'll now use the part number to ascertain the catalogue of what all parts are compatible together with your car. Now, you've got an inventory of all the brands and makers who produce the needed part. You’ll compare them, check the worth and place the order. One thing you would like to form sure is that they should accompany the return policy, just in case the part is flawed or doesn't fit well. You’ll search parts for your all the BMW models at AutoMartz to urge the BMW car parts catalog online in India. https://automartz.com/