Send quit-application in uriloader/exthandler/tests/unit_ipc/test_encoding.js

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
7 years ago
7 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

12 Branch
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 587028 [details] [diff] [review]
Send quit-application in uriloader/exthandler/tests/unit_ipc/test_encoding.js

https://tbpl.mozilla.org/?tree=Try&rev=afd596aad2ef
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #587028 - Flags: review?
Attachment #587028 - Flags: review? → review?(mak77)
Comment on attachment 587028 [details] [diff] [review]
Send quit-application in uriloader/exthandler/tests/unit_ipc/test_encoding.js

Review of attachment 587028 [details] [diff] [review]:
-----------------------------------------------------------------

::: uriloader/exthandler/tests/unit_ipc/test_encoding.js
@@ +6,5 @@
>  Cu.import("resource://gre/modules/Services.jsm");
>  
> +do_register_cleanup(function() {
> +  Services.obs.notifyObservers(null, "quit-application", null);
> +});

the harness fires profile close notifications as the first shutdown function, so doing this would notify quit-application after them, that is wrong.

This is actually a limitation in the harness header that internally uses the same do_register_cleanup call, should probably handle that differently to always keep it as the last task. See http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/head.js#744

So, could you file a bug and figure out how to ensure that cleanup task firing profile notifications is executed last?

That said, now that bug 713172 landed the DM shutdown at profile-before-change, so I think this bug is now wfm
Attachment #587028 - Flags: review?(mak77)
Yes, that patch fixed this bug too.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.