Closed
Bug 716592
Opened 12 years ago
Closed 12 years ago
Affiliates: en-US / browserID registered users are not able to sign up for newsletter
Categories
(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)
Firefox Affiliates Graveyard
affiliates.mozilla.org
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: cmore, Assigned: osmose)
Details
(Whiteboard: [dev][rel:1/12/2012])
Situation: User that sign up for Affiliates and use browserID do not get signed up for the newsletter regardless if they check the box. The code that is used to send out a request to basket is only in the legacy non-en-US code. Expected: A user signs up for Affiliates, checks the opt-in box to be signed up for the newsletter and they get signed up. Actual: The user does not get signed up regardless of their action.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mkelly
Whiteboard: [dev][rel:1/12/2012]
Comment 1•12 years ago
|
||
Where should we have test coverage for this? Selenium or in your test suite?
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 2•12 years ago
|
||
The basket patch (https://github.com/mozilla/affiliates/pull/78) has test coverage for this in the django test suite, as it'd be difficult to verify the subscription via selenium.
Comment 3•12 years ago
|
||
That looks great! https://github.com/Osmose/affiliates/blob/8ccf8b13d61e3513ea08dce7e47736423b8bcabe/apps/browserid/tests/test_views.py#L113 Should we have coverage for a non en-us local as well?
Comment 4•12 years ago
|
||
Commit pushed to https://github.com/mozilla/affiliates https://github.com/mozilla/affiliates/commit/1271439f267cac825b3199cdb1ec0a01c8089678 Add cache-machine to BannerInstance. fix bug 716592
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 5•12 years ago
|
||
QA verified on stage. mkelly thanks for helping verify the email address landed in the backend.
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Product: Websites → Firefox Affiliates
Updated•8 years ago
|
Product: Firefox Affiliates → Firefox Affiliates Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•