[meta] Don't add obviously live objects to the cycle collector graph

NEW
Unassigned

Status

()

Core
XPCOM
7 years ago
4 years ago

People

(Reporter: mccr8, Unassigned)

Tracking

(Depends on: 5 bugs, Blocks: 1 bug, {meta})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
If we can tell an object is currently live, then we don't need to add it to the cycle collector graph. The most common instance of this is documents that are currently being displayed. Another example is C++ objects being held alive by marked JS objects. There are also many objects where we can quickly check if they are being held alive by other objects that are obviously alive. Skipping these objects will reduce the size of the cycle collector graph, and avoid traversing their child nodes.  There is a danger of introducing transient leaks that don't show up at shutdown.

Smaug has done a lot of these small patches, and I think it makes sense to gather them together.  Sorry for the bug spam.
(Reporter)

Updated

7 years ago
Component: XPConnect → XPCOM
QA Contact: xpconnect → xpcom
(Reporter)

Updated

7 years ago
Keywords: meta
Whiteboard: [Snappy]
(Reporter)

Updated

7 years ago
Depends on: 702609, 702452, 712170, 714830
(Reporter)

Comment 1

7 years ago
Bug 705371 is more not adding obviously acyclic objects to the graph rather than obviously live, but close enough.
Depends on: 716106, 708322, 705371
(Reporter)

Updated

7 years ago
Depends on: 717500
(Reporter)

Updated

7 years ago
Depends on: 717557
(Reporter)

Updated

7 years ago
Depends on: 718340
(Reporter)

Updated

7 years ago
Depends on: 722715
(Reporter)

Updated

7 years ago
Depends on: 725804, 725752, 725768
(Reporter)

Updated

7 years ago
Depends on: 725447, 725446
(Reporter)

Updated

7 years ago
Depends on: 725867
(Reporter)

Updated

7 years ago
Depends on: 726331
(Reporter)

Updated

7 years ago
Depends on: 726340
(Reporter)

Updated

7 years ago
No longer depends on: 726331, 726340
(Reporter)

Comment 2

7 years ago
Meta bug, doesn't really need a Snappy tag.
Whiteboard: [Snappy]
(Reporter)

Updated

6 years ago
Depends on: 735342
(Reporter)

Updated

6 years ago
Depends on: 735504
(Reporter)

Updated

6 years ago
Depends on: 735550
(Reporter)

Updated

6 years ago
Depends on: 736563
(Reporter)

Updated

6 years ago
Depends on: 736763
(Reporter)

Updated

6 years ago
Depends on: 737060
(Reporter)

Updated

6 years ago
Depends on: 737075
(Reporter)

Updated

6 years ago
Depends on: 740185
(Reporter)

Updated

6 years ago
Depends on: 743199
No longer blocks: 698919
Blocks: 698919
(Reporter)

Updated

6 years ago
Depends on: 764899
(Reporter)

Updated

6 years ago
Depends on: 785493
(Reporter)

Updated

6 years ago
Depends on: 829784
(Reporter)

Updated

6 years ago
Depends on: 831360
(Reporter)

Updated

6 years ago
Depends on: 835544
(Reporter)

Updated

5 years ago
Depends on: 848827
(Reporter)

Updated

5 years ago
Depends on: 950205
(Reporter)

Updated

5 years ago
Depends on: 741760
(Reporter)

Updated

5 years ago
Depends on: 952872
You need to log in before you can comment on or make changes to this bug.