716635 - Pull deploy.py update assets into update() rather than pre_update()

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Tanay Gavankar [:tgavankar]]

deploy.py does asset updating (get_highcharts, compress_assets) in pre_update() right now, which is actually running for the next time deploy.py is supposed to run. The correct functionality should do asset updating in update() instead.

Comment 1

[Tanay Gavankar [:tgavankar]]

Done https://github.com/mozilla/kitsune/commit/bad4517.

As for verification, since -dev has TEMPLATE_DEBUG = True, we won't be able to tell if it worked on -dev, and so the steps for verification are to ensure that the js/css files are using the minified versions (filename-min.js?build=hash) rather than the individual source files. We should verify that it works on both staging as well as prod when it deploys.

Comment 2

[Rebecca Billings [:rbillings]]

Verified in staging, page source: /media/js/common-min.js?build=d708da6
Will verify post-release

Comment 3

[Rebecca Billings [:rbillings]]

Verified post release