71666 - If you do GetMsg() stop and then again GetMsg() you end up losing messages

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect, P1)

Description

[Navin Gupta]

Reproducible on win 2001030904 and linux 2001030913.

Expected results: should not lose messages
Actual results: loss of messages

Comment 1

[Navin Gupta]

nominating because there is dataloss

Comment 2

[laurel]

You may want to provide a few more details for Sheela so she knows what is
needed to reproduce the problem.

Comment 3

[Navin Gupta]

The background info is in bug 67799

Comment 4

[Navin Gupta]

Attachment: proposed fix

Comment 5

[David :Bienvenu]

please explain the logic behind the fix.

Comment 6

[Navin Gupta]

When you hit stop then you try to commit the current state by removing 
the last uidl entry in the struct newuidl. Removing last entry is not
enough because it so happens that even before a msg has been fully 
downloaded and written to the disk we start processing the next msg. 
So we end up have two entries more in newuidl structure. Therefore 
remove these two uidl entries from newuidl and then save the state in
popstate.dat

cc bienvenu

Comment 7

[David :Bienvenu]

So I think that would be worth a comment in the code. Also, what if, for some
reason, there's only one extra entry there (e.g., you only have one message to
download and interrupt the download of that msg) - shouldn't we check for that
in the code?

Comment 8

[scottputterman]

marking nsbeta1+

Comment 9

[Navin Gupta]

Attachment: better fix

Comment 10

[David :Bienvenu]

r=bienvenu

Comment 11

[Navin Gupta]

I noticed that IncorporateComplete was getting called twice for each message
being downloaded. To enusre that complete is called only once, made changes 
to the last patch. We need to do so to avoid publishing the header twice in
some cases. I found one such case, where message size was 66kb and message 
downloading was interrupted by "Stop".

Comment 12

[Navin Gupta]

Attachment: revised patch

Comment 13

[Navin Gupta]

Sorry, ignore the last patch dated 03/16/01 14:12. 

Comment 14

[Navin Gupta]

Attachment: correct revised patch

Comment 15

[Navin Gupta]

David, I am assuming r= on the last patch here.

Comment 16

[Navin Gupta]

fix checked in.

Comment 17

[Navin Gupta]

Please verify this only for leave messages on the server (X).

Comment 18

[Sheela Ravindran]

Unable to verify this bug due to bug 74471. See bug 74471 for details

Comment 19

[Sheela Ravindran]

verified, 
2001-04-04-12win98
2001-04-04-14linux
2001-04-04-08mac
clicking get mssg stop and get mssg does not result in losing message.
Preference for pop was Leave messages on the server when I verified this bug.