Closed Bug 716732 Opened 8 years ago Closed 8 years ago

Robocop: fennec_ids.txt not always generated

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla12

People

(Reporter: gbrown, Assigned: jmaher)

Details

Attachments

(1 file)

Both :kats and I have had trouble with fennec_ids.txt today:
 - an old version of the file might be used (it is not cleaned up at the start of a test)
 - it seems to be re-generated by make package-tests, which (I think) would not otherwise be required to run make mochitest-robotium (it would be better if it were generated as part of the mochitest-robotium rule, if possible)
Also, I see this message from 'make mochitest-robotium':

cannot stat '/home/mozdev/src/objdir-native-droid/build/mobile/robocop/robocop.ini/fennec_ids.txt': Not a directory

Note the "robocop.ini" -- what's that doing in there?
this patch cleans up a handful of things related to fennec_ids.txt.  First off it is generated and copied to a different place.  Also we clean up any instance of it on the device before running tests.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #587564 - Flags: review?(bugmail.mozilla)
Comment on attachment 587564 [details] [diff] [review]
allow for generation of fennec_ids.txt during make mochitest-robotium (1.0)

Review of attachment 587564 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit addressed

::: testing/testsuite-targets.mk
@@ +80,3 @@
>      --console-level=INFO --log-file=./$@.log --file-level=INFO $(DM_FLAGS) --dm_trans=adb \
>      --app=$(TEST_PACKAGE_NAME) --deviceIP=${TEST_DEVICE} --xre-path=${MOZ_HOST_BIN} \
> +    --robocop $(DEPTH)/build/mobile/robocop/robocop.ini $(SYMBOLS_PATH) $(TEST_PATH_ARG) $(EXTRA_TEST_ARGS)

nit: For consistency this should have an equals instead of a space between --robocop and $(DEPTH)? It seems like all the other options use the form --key=value rather than --key value.

@@ +286,5 @@
>  	rm -rf $(PKG_STAGE) && $(NSINSTALL) -D $(PKG_STAGE) && $(NSINSTALL) -D $(PKG_STAGE)/bin && $(NSINSTALL) -D $(PKG_STAGE)/bin/components && $(NSINSTALL) -D $(PKG_STAGE)/certs && $(NSINSTALL) -D $(PKG_STAGE)/jetpack && $(NSINSTALL) -D $(PKG_STAGE)/firebug && $(NSINSTALL) -D $(PKG_STAGE)/peptest && $(NSINSTALL) -D $(PKG_STAGE)/mozbase
>  
> +robotium-id-map:
> +ifeq ($(MOZ_BUILD_APP),mobile/android)
> +	$(PYTHON) $(DIST)/../build/mobile/robocop/parse_ids.py -i $(DEPTH)/mobile/android/base/R.java -o $(DEPTH)/build/mobile/robocop/fennec_ids.txt

Why does this use $(DIST)/../ instead of $(DEPTH) to find parse_ids.py? Shouldn't they always be the same?
Attachment #587564 - Flags: review?(bugmail.mozilla) → review+
Works for me: generates fennec_ids.txt without package-tests, and no visible errors.


Can you also clean-up:

http://mxr.mozilla.org/mozilla-central/source/build/mobile/robocop/Makefile.in#114

parse_ids.txt looks like a typo to me.
https://hg.mozilla.org/mozilla-central/rev/d56f08ec0225
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.