716784 - Enable FAIL_ON_WARNINGS in services/

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Gregory Szorc [:gps]]

It looks like the Makefiles have support for failing builds if there are compiler warnings now. I think code should be warning free, so I'd like to turn this on for services/*.

Comment 1

[Gregory Szorc [:gps]]

Try build at https://tbpl.mozilla.org/?tree=Try&rev=6b9acbb6658f

Comment 2

[Gregory Szorc [:gps]]

Attachment: Enable FAIL_ON_WARNINGS in services/

There is only one directory/Makefile in services/ that compiles stuff, so I only think there is one place where I need the magic FAIL_ON_WARNINGS variable. If you want me to put it everywhere, I could certainly do that.

Comment 3

[Gregory Szorc [:gps]]

Pushed to s-c: https://hg.mozilla.org/services/services-central/rev/d3dc18e55d43

Comment 4

[Gregory Szorc [:gps]]

Merged into m-c: https://hg.mozilla.org/mozilla-central/rev/d3dc18e55d43

Comment 5

[Gregory Szorc [:gps]]

We don't need QA on this. Either the tree builds or it doesn't.

Comment 6

[Daniel C]

Comment on attachment 587233 [details] [diff] [review]
Enable FAIL_ON_WARNINGS in services/

Review of attachment 587233 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/crypto/component/Makefile.in
@@ +42,5 @@
>  VPATH     = @srcdir@
>  
>  include $(DEPTH)/config/autoconf.mk
>  
> +FAIL_ON_WARNINGS := 1

Shouldn't that be = rather than := ?

Comment 7

[Gregory Szorc [:gps]]

(In reply to Daniel Cater from comment #6)
> > +FAIL_ON_WARNINGS := 1
> 
> Shouldn't that be = rather than := ?

For variable values that don't have variable or function references, ':=' is perfectly acceptable and personally preferred. See https://www.gnu.org/software/make/manual/make.html#Flavors.