Closed Bug 716784 Opened 8 years ago Closed 8 years ago

Enable FAIL_ON_WARNINGS in services/

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

Details

(Whiteboard: [fixed in services][qa-])

Attachments

(1 file)

It looks like the Makefiles have support for failing builds if there are compiler warnings now. I think code should be warning free, so I'd like to turn this on for services/*.
There is only one directory/Makefile in services/ that compiles stuff, so I only think there is one place where I need the magic FAIL_ON_WARNINGS variable. If you want me to put it everywhere, I could certainly do that.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #587233 - Flags: review?(ted.mielczarek)
Attachment #587233 - Flags: review?(ted.mielczarek) → review+
Pushed to s-c: https://hg.mozilla.org/services/services-central/rev/d3dc18e55d43
Whiteboard: [fixed in services]
Merged into m-c: https://hg.mozilla.org/mozilla-central/rev/d3dc18e55d43
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
We don't need QA on this. Either the tree builds or it doesn't.
Whiteboard: [fixed in services] → [fixed in services][qa-]
Comment on attachment 587233 [details] [diff] [review]
Enable FAIL_ON_WARNINGS in services/

Review of attachment 587233 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/crypto/component/Makefile.in
@@ +42,5 @@
>  VPATH     = @srcdir@
>  
>  include $(DEPTH)/config/autoconf.mk
>  
> +FAIL_ON_WARNINGS := 1

Shouldn't that be = rather than := ?
(In reply to Daniel Cater from comment #6)
> > +FAIL_ON_WARNINGS := 1
> 
> Shouldn't that be = rather than := ?

For variable values that don't have variable or function references, ':=' is perfectly acceptable and personally preferred. See https://www.gnu.org/software/make/manual/make.html#Flavors.
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.