The tab icon for individual messages is ugly

RESOLVED FIXED in Thunderbird 53.0

Status

Thunderbird
Theme
--
minor
RESOLVED FIXED
6 years ago
11 months ago

People

(Reporter: florian, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 53.0
x86
Mac OS X

Thunderbird Tracking Flags

(thunderbird52 fixed, thunderbird53 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

6.40 KB, patch
Paenglab
: review+
Jorg K (GMT+1) [currently bustage-fix only, no NI? or r?]
: approval-comm-aurora+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
The tab icon for tabs displaying a single message on Mac is very ugly: it's a 17*12px icon scaled to 16*16px, resulting in a very blurry icon.

The file used is:
http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/icons/message-mail.png

The CSS rule to change once there is a new icon is:
http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/mailWindow1.css#522
New location for file: http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/icons/message-mail.png

New location for CSS: http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/mailWindow1.css#558
(Assignee)

Comment 2

11 months ago
Created attachment 8821978 [details] [diff] [review]
mailIcon.patch

Would this be better? I also added a HiDPI icon.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8821978 - Flags: review?(florian)
(Reporter)

Comment 3

11 months ago
Comment on attachment 8821978 [details] [diff] [review]
mailIcon.patch

Review of attachment 8821978 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks like changing the icon file will fix the bug :-).

$ file mail/themes/osx/mail/icons/message-mail*
mail/themes/osx/mail/icons/message-mail-attach.png:     PNG image data, 16 x 16, 8-bit/color RGBA, non-interlaced
mail/themes/osx/mail/icons/message-mail-imapdelete.png: PNG image data, 16 x 12, 8-bit/color RGBA, non-interlaced
mail/themes/osx/mail/icons/message-mail-new.png:        PNG image data, 16 x 12, 8-bit/color RGBA, non-interlaced
mail/themes/osx/mail/icons/message-mail.png:            PNG image data, 16 x 16, 8-bit/color RGB, non-interlaced
mail/themes/osx/mail/icons/message-mail@2x.png:         PNG image data, 32 x 32, 8-bit/color RGB, non-interlaced

Looks like the message-mail-imapdelete.png and message-mail-new.png images also have incorrect sizes.
But http://searchfox.org/comm-central/search?q=message-mail- shows none of the message-mail-{attach,imapdelete,new}.png files is used in mail/, so may be can just remove them?

I tried applying the patch locally, but I haven't rebuilt to test it; my r+ assumes you tested it. If you have not, then I would wonder if the HiDPI icon will be scaled correctly and if we need to explicitly set the height and width to 16px (maybe by just moving the height/width lines from the .tabmail-tab[type="message"][IsFeedMessage] block to the less specific .tabmail-tab[type="message"] block?
Attachment #8821978 - Flags: review?(florian) → review+
(Assignee)

Comment 4

11 months ago
Created attachment 8822026 [details] [diff] [review]
mailIcon.patch

(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> Comment on attachment 8821978 [details] [diff] [review]
> mailIcon.patch
> 
> Review of attachment 8821978 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, looks like changing the icon file will fix the bug :-).
> 
> Looks like the message-mail-imapdelete.png and message-mail-new.png images
> also have incorrect sizes.
> But http://searchfox.org/comm-central/search?q=message-mail- shows none of
> the message-mail-{attach,imapdelete,new}.png files is used in mail/, so may
> be can just remove them?

Removed them now.

> I tried applying the patch locally, but I haven't rebuilt to test it; my r+
> assumes you tested it. If you have not, then I would wonder if the HiDPI
> icon will be scaled correctly and if we need to explicitly set the height
> and width to 16px (maybe by just moving the height/width lines from the
> .tabmail-tab[type="message"][IsFeedMessage] block to the less specific
> .tabmail-tab[type="message"] block?

This is not needed because the icon size is already defined in https://dxr.mozilla.org/comm-central/source/mail/themes/shared/mail/tabmail.css#72
Removed now the size in .tabmail-tab[type="message"][IsFeedMessage]
Attachment #8822026 - Flags: review+
(Assignee)

Updated

11 months ago
Keywords: checkin-needed
Comment on attachment 8821978 [details] [diff] [review]
mailIcon.patch

I guess you only want to check in one patch, not two ;-)
Attachment #8821978 - Attachment is obsolete: true
(Assignee)

Comment 6

11 months ago
Correct :)
https://hg.mozilla.org/comm-central/rev/a9fb07672b41fbcd4ae5025b2e9ab7172304b824
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
(Assignee)

Comment 8

11 months ago
Comment on attachment 8822026 [details] [diff] [review]
mailIcon.patch

[Approval Request Comment]
User impact if declined: ugly, blurry icon
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8822026 - Flags: approval-comm-aurora?
Attachment #8822026 - Flags: approval-comm-aurora? → approval-comm-aurora+
Aurora (TB 52):
https://hg.mozilla.org/releases/comm-aurora/rev/f53bfb3398e6131726772f78e1afcd212994f9a5
status-thunderbird52: --- → fixed
status-thunderbird53: --- → fixed
You need to log in before you can comment on or make changes to this bug.