716934 - Robotium tests might silently fail to click

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Check for click() returning false

Haven't actually seen this happen, but while debugging came across the possibility and figured we should check for it.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 587356 [details] [diff] [review]
Check for click() returning false

Review of attachment 587356 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/mobile/robocop/FennecNativeElement.java.in
@@ +77,5 @@
>            public void run() {
>              View view = (View)mActivity.findViewById(id);
>              if(view != null) {
> +              if (!view.performClick()) {
> +                Log.w("Robocop", "Robocop called click on an element with no listener");

I would like these messages to make it in the log file.  I think this is a subject for another bug.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d427e719ed9

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4d427e719ed9