717010 - nsHTMLDocument.cpp:1749:12: warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 716338 turned on warnings-as-errors in content/html/content/src/Makefile.in

This breaks my local build (with --enable-warnings-as-errors), due to this build warning:
{
  nsHTMLDocument.cpp:1749:12: warning: variable ‘rv’ set but not used [-Wunused-but-set-variable]
}

Comment 1

[Daniel Holbert [:dholbert]]

Conveniently, the set-but-not-used value is just:
> 1749   nsresult rv = NS_OK;

So we can basically just drop that line. Patch coming up.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: partial fix: move |rv| down to where it's set. (It still never gets read, though...)

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> This breaks my local build (with --enable-warnings-as-errors), due to this
> build warning:

Sorry -- I misread my build output.  This particular warning doesn't break my build, because it's in html/document and FAIL_ON_WARNINGS has only been added in html/content thus far.

Still, worth fixing.

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 587450 [details] [diff] [review]
partial fix: move |rv| down to where it's set. (It still never gets read, though...)

Hmm, nevermind -- |rv| is still unused even after we capture mParser->Parse()'s return value, so with this patch, GCC just warns about the new lower-down line where |nsresult rv| is unused.

Not sure whether we should be caring about mParser->Parse()'s result. (We're saving it but ignoring it, right now...)