Closed Bug 717056 Opened 8 years ago Closed 8 years ago

More Android Sync setup strings

Categories

(Firefox for Android :: Android Sync, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12
Tracking Status
firefox11 --- fixed

People

(Reporter: liuche, Assigned: rnewman)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Used in screens when Android Sync fails due to lack of internet on device.

Changes on github:
https://github.com/mozilla-services/android-sync/commit/99214c4cc40d1cc1d6592afbc460017a6e12dd20#strings.xml.in

strings.xml.in and sync_strings.dtd.in
Target Milestone: mozilla12 → ---
This change:

* Removes the embedded HTML from sync.link.* strings (Chenxia found an alternative approach);
* Adds sync.subtitle.nointernet.label and sync.button.ok.label.

As with Bug 716760, we're slipping these in ahead of time to get them into Aurora before a string freeze.
Summary: "No Internet Connection" string addition → More Android Sync setup strings
Attachment #587573 - Flags: review?(blassey.bugs)
Attachment #587573 - Flags: review?(blassey.bugs) → review+
Thanks Brad!

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/5461d5635ca9
Status: NEW → ASSIGNED
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/5461d5635ca9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Bad idea, I think you should have changed name entities here

-<!ENTITY sync.link.show.label '<a href="https://support.mozilla.com/kb/add-a-device-to-firefox-sync">Show me how</a>'>
-<!ENTITY sync.link.nodevice.label '<a href="#">I don\&apos;t have the device with me…</a>'>
+<!ENTITY sync.link.show.label 'Show me how.'>
+<!ENTITY sync.link.nodevice.label 'I don\&apos;t have the device with me…'>
(In reply to flod (Francesco Lodolo) from comment #6)
> Bad idea, I think you should have changed name entities here

Is that the case even for a preffed-off feature that has barely landed in Nightlies? (Genuine question, I was under the impression that nobody would have attempted to localize these strings yet.)
I see 5 locales with wrong translations, and that's just because the other 6 already fixed these strings. 

http://mxr.mozilla.org/l10n-central/search?string=sync.link.show.label&find=%2Fmobile&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central

The alternative to change the entity name now is to keep those 6 locales under control or warn their owner if they don't catch the change.
(In reply to Richard Newman [:rnewman] from comment #7)
> Is that the case even for a preffed-off feature that has barely landed in
> Nightlies? (Genuine question, I was under the impression that nobody would
> have attempted to localize these strings yet.)

As soon as something has landed, some people are going to start localizing it - and they don't see what's preffed off or on as the strings are there in the locales/ directory and showing up as "missing" strings in our L10n tools.
The best rule to follow is: Once strings have landed and you change them in a way that need localizers to look at them again when they already have localized the former ones, then you need to change the string IDs as well.
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #9)

> As soon as something has landed, some people are going to start localizing
> it - and they don't see what's preffed off or on as the strings are there in
> the locales/ directory and showing up as "missing" strings in our L10n tools.

I see. I got the impression from Axel recently that there was little point landing strings before the feature was available, because it would be difficult or impossible to localize; I suppose that meant "localize well"!

Thanks for clarifying.
Right, that meant "localize well". That's all I care about so I don't mention it explicitly. Black magick.

To recap, don't spend time on prelanding strings but land the functional code. As even if you preland, you have to pretend that they're all correctly localized and be all paranoid, and that's really a lot of work for a string that's not used yet.
Richard, please request aurora approval
(In reply to Brad Lassey [:blassey] from comment #12)
> Richard, please request aurora approval

No need; already arrived in the 0.3 merge this week. Aurora and m-c are identical for Sync right now.
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.