717058 - Add an "options" property to package.json for custom options.xul files

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, enhancement)

Description

[blackwind]

I'm getting tired of adding this functionality to the SDK myself on every new release, so I figured I'd share my work with the community.

While the simple-prefs module now provides an avenue for the inclusion of inline options, it's far from complete, and there'll always be cases where it's advantageous to code options.xul by hand; therefore, I propose an extra packages.json property, "options", which allows one to specify a custom options.xul file. If "options.xul" is found in the add-on's folder, it should be included in the build automatically, just as "icon" and "icon64" currently are.

Attached is a two-part patch for 1.4 final which accomplishes these goals. It was created with "diff". I don't have time to learn git, but it's a simple patch, so hopefully what's here will be sufficient for someone to run with it.

Comment 1

[blackwind]

Attachment: Patch for python-lib/cuddlefish/packaging.py

Comment 2

[blackwind]

Attachment: Patch for python-lib/cuddlefish/xpi.py

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Brian, Alex, what do you guys think about these changes?

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

What is missing from simple-prefs that you'd like to do?

Comment 5

[blackwind]

Menulists. I also need to specify ids for my menulists so I can programmatically add new items at runtime, and I'm unable to use simple-prefs at all until bug 717062 is resolved.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Could you open a new bug specifically for adding menulists and the other things you want into simple-prefs?

We're wontfixing this because we want to make sure that whatever the SDK is using can survive Firefox changing the way it deals with options.