717060 - If flash player is running in multiple tabs, Fennec will crash with no crash report

Status: RESOLVED DUPLICATE of bug 719872

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat

1. open a tab to www.cnn.com/video and play a video
2. open another tab to www.cnn.com/video and play a different video

Expected: only the front most video will play
Actual: fennec will crash

Note:
1. nexus S, Android 2.3.1, Flash 11, build 20120110

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Relevant section of logcat:
01-10 14:54:29.664: I/GeckoJNI(974): void Java_org_mozilla_gecko_GeckoAppShell_executeNextRunnable(JNIEnv*, _jclass*)
01-10 14:54:29.714: I/GeckoJNI(974): leaving void Java_org_mozilla_gecko_GeckoAppShell_executeNextRunnable(JNIEnv*, _jclass*)
01-10 14:54:29.746: D/GeckoSoftwareLayerClient(974): Received viewport update from gecko
01-10 14:54:29.746: D/GeckoLayerController(974): setViewportMetrics: v=RectF(0.0, 0.0, 800.0, 379.0) p=(869.0,724.0) z=0.81632656 o=0.0,0.0
01-10 14:54:29.746: I/GeckoApp.PluginLayoutParams(974): Repositioning plugin by 0, 0, (81.63265%)
01-10 14:54:29.750: W/System.err(974): android.view.ViewRoot$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
01-10 14:54:29.753: W/System.err(974): 	at android.view.ViewRoot.checkThread(ViewRoot.java:2932)
01-10 14:54:29.753: W/System.err(974): 	at android.view.ViewRoot.requestLayout(ViewRoot.java:629)
01-10 14:54:29.753: W/System.err(974): 	at android.view.View.requestLayout(View.java:8267)
01-10 14:54:29.753: W/System.err(974): 	at android.view.View.requestLayout(View.java:8267)
01-10 14:54:29.753: W/System.err(974): 	at android.view.View.requestLayout(View.java:8267)
01-10 14:54:29.753: W/System.err(974): 	at android.view.View.requestLayout(View.java:8267)
01-10 14:54:29.753: W/System.err(974): 	at android.widget.RelativeLayout.requestLayout(RelativeLayout.java:257)
01-10 14:54:29.753: W/System.err(974): 	at android.view.View.requestLayout(View.java:8267)
01-10 14:54:29.753: W/System.err(974): 	at android.view.View.requestLayout(View.java:8267)
01-10 14:54:29.753: W/System.err(974): 	at android.view.View.setLayoutParams(View.java:5000)
01-10 14:54:29.753: W/System.err(974): 	at android.view.ViewGroup.updateViewLayout(ViewGroup.java:1884)
01-10 14:54:29.753: W/System.err(974): 	at org.mozilla.gecko.GeckoApp.repositionPluginViews(GeckoApp.java:1395)
01-10 14:54:29.753: W/System.err(974): 	at org.mozilla.gecko.gfx.LayerController.setViewportMetrics(LayerController.java:233)
01-10 14:54:29.753: W/System.err(974): 	at org.mozilla.gecko.gfx.GeckoSoftwareLayerClient.updateViewport(GeckoSoftwareLayerClient.java:207)
01-10 14:54:29.753: W/System.err(974): 	at org.mozilla.gecko.gfx.GeckoSoftwareLayerClient.endDrawing(GeckoSoftwareLayerClient.java:223)
01-10 14:54:29.753: W/System.err(974): 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
01-10 14:54:29.753: W/System.err(974): 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
01-10 14:54:29.753: W/System.err(974): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:453)
01-10 14:54:29.753: W/System.err(974): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:107)

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 589527 [details] [diff] [review]
patch

I don't like this because it spins off a runnable every time, regardless of whether or not we're already on the UI thread. I would rather fix whatever call site is using the wrong thread.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

it looks like bug 712037 already fixed the call site. Finkle, can you confirm you were testing a build with out that patch?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Naoki, please retest with bug 712037 fixed

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat

Nexus S Logcat from 2012-01-22 build

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Looks like this crashed due to skia this time?  https://crash-stats.mozilla.com/report/index/868ae9b2-cbb8-46b0-91a2-7838a2120122

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Bug 719872 is reporting the same skia crash.