717086 - No error messages if Sync fails

Status: RESOLVED DUPLICATE of bug 709393

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Tony Chung [:tchung]]

Attachment: logcat

Forcing sync account to sync (when there's an error), does not show any errors on the phone.   We need some kind of error message shown to the user.

Logcat attached.

Repro:
1) install rnewman's 1-9-2012 sync build
2) Open Settings > accounts > add Account > Firefox Sync
3) setup an incorrect account (see bug 717082)
4) once setup is successful, go to Sync Settings, and click menu item "Sync Now"
5) since this fake account will fail (see logcat), syncing should fail
6) Verify no error messaging when sync fails

Expectd:
- setup should fail, and tell user so

Actual:
- no error messaging that sync has failed.

Comment 1

[Richard Newman [:rnewman]]

There's a difference between "we should validate credentials before completing setup" and "we should notify on sync failures".

The former is Bug 705767. The latter is taken care of by Android; we increment counters, and Android will eventually report failures.

Handling of now-incorrect credentials is Bug 709393, and this seems closest to that one, so I'm going to dupe to that.