'this' inside Hotkey.onPress is [object Sandbox]

RESOLVED FIXED

Status

Add-on SDK
General
P3
normal
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: dietrich, Assigned: jsantell)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
it should be the Hotkey object.
Was it ever the Hotkey object? Did this change with 1.4?
Priority: -- → P3
Blocks: 908030
(Assignee)

Updated

4 years ago
Assignee: nobody → jsantell
Created attachment 800121 [details]
bug

`this` is not [Sandbox] at this point, but it was undefined; should be the hotkey instance itself, I think.
Attachment #800121 - Flags: review?(zer0)
Attachment #800121 - Flags: review?(zer0) → review+

Comment 3

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f698ea91f47f4fc12d4d1559b089bfa5da3ba052
Bug 717166 Change context of hotkey onPress to the hotkey instance itself

https://github.com/mozilla/addon-sdk/commit/bdc2ffcef77578494dfc0ff42aa3a51c018852e0
Merge pull request #1233 from jsantell/717166-change-hotkey-onpress-context

fix Bug 717166 Change context of hotkey onPress to the hotkey instance itself, r=@ZER0

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.