The Netvibe portal is no longer loading the content of your personal page in the latest nightlies (you need to sign up to their service to see it), instead of displaying your Netvibes home page, you get a "please wait a moment..." message. using the mozregression tool, the regression happened yesterday, here is the result of the tool: Last good nightly: 2012-01-09 First bad nightly: 2012-01-10 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9a230265bad5&tochange=c713003d3226 The error console throws 2 errors in the Nightly: [09:39:37,062] a.$family is undefined @ http://cdn.netvibes.com/js/c/Netvibes.js?v=1359:1 [09:39:37,252] App.Start is not a function @ http://www.netvibes.com/privatepage/1#General:382 I do not see these errors when I use Firefox 9.0.1 (This problem was reported in the French Mozilla Community forums geckozone.org)
Regression window(m-i) Works: http://hg.mozilla.org/integration/mozilla-inbound/rev/b6c60a28454d Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120107 Firefox/12.0a1 ID:20120109062923 Fails: http://hg.mozilla.org/integration/mozilla-inbound/rev/7ab4f1ebc7cc Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120109 Firefox/12.0a1 ID:20120109063028 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b6c60a28454d&tochange=7ab4f1ebc7cc Triggered by: 7ab4f1ebc7cc Brian Hackett — Backout 54cd89b0f1fa (bug 712714 backout). Talos will probably report fake regressions for this patch, do not back out for this reason.
6 years ago
Created attachment 587880 [details] [diff] [review] patch When generating code for property accesses that can invoke a getter hook on the object, there was a stupid test for the 'length' property to ensure that the necessary sync code was executed if the input is a string. This special case broke with bug 712714, as now PICs can be generated for any property on strings in either the normal or call context.
Both Netvibes and jsfiddle work in today's nightly, thanks