717215 - Remove references to url_quote filter

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Simon Green]

Attachment: diff

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111223083612

Steps to reproduce:

With bug 398701 now implemented, there were still two references to the url_quote filter.



Expected results:

These references should be changed from url_quote to uri.

Comment 1

[Simon Green]

This is only for the url_quote filter that was part of Bugzilla::Template, and removed in bug 398701. Note there is still the url_quote subroutine in Bugzilla::Utils

I've attached a patch to fix this. Not a major issue at all, but good to clean it up nonetheless.

  -- simon

Comment 2

[Simon Green]

Attachment: diff without my name in the contributors list

Comment 3

[Frédéric Buclin]

Comment on attachment 587666 [details] [diff] [review]
diff without my name in the contributors list

>=== modified file 'template/en/default/bug/field.html.tmpl'

>   #   desc_url: string; Normally the label of a non-custom field links to
>   #             fields.html. If you want it to link elsewhere, specify the
>   #             relative URL you want to link to, here. Remember to call
>-  #             url_quote on any query string arguments.
>+  #             the uri filter on any query string arguments.

Actually, desc_url no longer exists in this template, and this description must go away. It has been moved into template/en/default/bug/field-label.html.tmpl where the description is already correct, see bug 555850.


>=== modified file 'template/en/default/filterexceptions.pl'

>+#   where the filter is one of html|csv|js|uri|quoteUrls|time|uri|xml|none

uri is now mentioned twice                   ^^^                ^^^

Comment 4

[Simon Green]

Attachment: v2 patch

Fixed the two problems identified.

Definitely trivial :)

Comment 5

[Frédéric Buclin]

Comment on attachment 587670 [details] [diff] [review]
v2 patch

Thanks! :) r=LpSolit

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/filterexceptions.pl
modified template/en/default/bug/field.html.tmpl
Committed revision 8077.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified template/en/default/filterexceptions.pl
modified template/en/default/bug/field.html.tmpl
Committed revision 8007.