717299 - Tab close box is too small

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Gervase Markham [:gerv]]

The tab close box is too small; I often overshoot it with my thumb and select the tab instead, which closes the tab switcher but not the tab. After wondering why "it didn't work", I reopen the tab switcher (across the other side of the screen) and have another try. This is not awesome.

The tab close box needs to have a bigger target area - at the very least extending to the top and bottom of the tab's horizontal bar - and the exact area needs to be defined by some border (currently, the X is in the middle of an area of grey, some of which is part of the button and some of which is not). 

And, to reduce the risk of people clicking the X when clicking the thumbnails, they should be over the other side. Then there also wouldn't be confusion over whether the little grey tab is part of the close box or part of the area to select the tab (it turns out to be the latter, but it's contiguous with the former).

Lastly, the text size is tiny - the titles of my current tabs occupy about 1% of the area available. They need a significant boost. They could be 3x the font size and you could still fit in three lines of text!

Asus EEE Transformer, Fennec Native Aurora, today's build.

Gerv

Comment 1

[Madhava Enros [:madhava]]

Hi Gerv -

Do you find the same issues with the native UI on a phone-sized device? I haven't been noticing this myself, but I should try it out on a tablet. Tablet-specific designs are going to be coming in the next release.

Comment 2

[Gervase Markham [:gerv]]

Hi Madhava: on my Nexus One the graphical and "hit box" issues (needs borders, etc.) are still there - because the styling is exactly the same. The overall size of the close area is a bit better. The text size is a lot more appropriate (basically, it seems to be the same size in mm on both the phone and the tablet, which is probably wrong for the tablet). 

So I think a lot, but not all, of this bug applies to the phone version.

Gerv

Comment 3

[Doug Turner (:dougt)]

over to madhava.

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Propose to spread close button area

I propose to spread close button area.
I seem it will be easy to use that to make the area surrounded by red line into close button.

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: propose to spread close button area

I propose to spread close button area.
I seem it will be easy to use that to make the area surrounded by red line into close button.

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Sorry. I uploaded the wrong image as attachment 591098 [details].

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

There are several bugs here, we need separate bugs and UX for those

Comment 8

[Gervase Markham [:gerv]]

Madhava: if you can give some guidance about which of the issues in this bug you think should be fixed, I can do some splitting.

Gerv

Comment 9

[Wesley Johnston (:wesj)]

Attachment: Patch for close button size

This makes the close button the height of the row (close to what's shown in the attachment). Not sure if we want this or not. Also Sriram, do you know why we can't just use layout_height="match_parent" here? Android layouts confuse me sometimes...

build at: http://people.mozilla.com/~wjohnston/bigclose.apk

Comment 10

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 600953 [details] [diff] [review]
Patch for close button size

Review of attachment 600953 [details] [diff] [review]:
-----------------------------------------------------------------

I wouldn't be doing this way. :( It's better to preserve the width and height of the actual image in layout_width and layout_height and just change the padding values as needed.

Comment 11

[Sriram Ramasubramanian [:sriram]]

The reason layout_height might not work is because the parent might do a "wrap_content" or something. If it's not "fill_parent" or an absolute value, we will run into this issue.

Comment 12

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Wesley Johnston (:wesj) from comment #9)
> 
> build at: http://people.mozilla.com/~wjohnston/bigclose.apk

I have used test-build. I feel like good.

Comment 15

[Kevin Brosnan [Ex-Mozilla]]

Lets leave this bug as tab buttons are too small. bug 750133 can cover the right side. File a new bug for the text size.

Comment 16

[Gervase Markham [:gerv]]

Bug 750199 filed for text size.

Gerv

Comment 18

[Peter Retzer (:pretzer)]

The close button is stretched over the full tab height for some time now, so I think this can be closed.