Last Comment Bug 717370 - Cleanup range-using and nearby code in editor
: Cleanup range-using and nearby code in editor
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Makoto Kato [:m_kato]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-11 12:57 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-01-15 03:24 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (13.32 KB, patch)
2012-01-11 12:57 PST, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-01-11 12:57:48 PST
Created attachment 587791 [details] [diff] [review]
Patch v1

Looking at the patches for bug 682611, I noticed at least three helper functions to create a range and set its start and end points, and one function that did it inline. I'd say we can provide that in one place.

Smaug, could you review the changes in nsRange.{h,cpp}?

Also, various ugly and slow stuff I noticed.
Comment 1 :Ehsan Akhgari 2012-01-11 13:10:12 PST
Comment on attachment 587791 [details] [diff] [review]
Patch v1

Review of attachment 587791 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the editor parts.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-01-15 03:24:11 PST
https://hg.mozilla.org/mozilla-central/rev/fb524533a477

Note You need to log in before you can comment on or make changes to this bug.