Cleanup range-using and nearby code in editor

RESOLVED FIXED in mozilla12

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 587791 [details] [diff] [review]
Patch v1

Looking at the patches for bug 682611, I noticed at least three helper functions to create a range and set its start and end points, and one function that did it inline. I'd say we can provide that in one place.

Smaug, could you review the changes in nsRange.{h,cpp}?

Also, various ugly and slow stuff I noticed.
Attachment #587791 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Attachment #587791 - Flags: review?(ehsan)
Comment on attachment 587791 [details] [diff] [review]
Patch v1

Review of attachment 587791 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the editor parts.
Attachment #587791 - Flags: review?(ehsan) → review+

Updated

5 years ago
Attachment #587791 - Flags: review?(bugs) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fb524533a477
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.