717431 - "No updates available" shouldn't change back to "Check for updates"

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Michael Kohler [:mkohler]]

"No updates available" shouldn't change back to "Check for updates" since the "About" window in desktop Firefox doesn't do it either.

Comment 1

[Michael Kohler [:mkohler]]

Attachment: Patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Honestly, I kinda like being able to check again. Asking UX for final say though.

Madhava - what say you?

Comment 3

[Michael Kohler [:mkohler]]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Honestly, I kinda like being able to check again. Asking UX for final say
> though.
> 
> Madhava - what say you?

I think just reloading the page isn't such a PITA.

We could also link the "No updates available" to checkForUpdates() instead, but I'm not quite sure if that is any improvement UX wise.

Comment 4

[Doug Turner (:dougt)]

tracking.  Madhava, what say you?

Comment 5

[Madhava Enros [:madhava]]

Why wouldn't we let people check again? This is mostly a developer tool - I'm not sure I worry too much about people getting confused and tapping it again and again, which I'd think is the only reason to shut it down for a while.

Comment 6

[Madhava Enros [:madhava]]

I mean, that said -- I'm honestly curious -- why do you think we shouldn't do this?

Comment 7

[Michael Kohler [:mkohler]]

(In reply to Madhava Enros [:madhava] from comment #6)
> I mean, that said -- I'm honestly curious -- why do you think we shouldn't
> do this?

I think it's better to make sure that the user has enough information. If you need to check again, a page reload is enough to display the button in its initial state.

Adding the checkForUpdates function to "No updates available" could fix both problems (information and recheck). Would that be better?

Comment 8

[Michael Kohler [:mkohler]]

Madhava?

Comment 9

[Kevin Brosnan [Ex-Mozilla]]

The problem this bug is when the update server takes more than a second or two to reply and you look away from the phone. If you know the behavior well then yes you can infer that if there is no notice in the notification bar then there was no update. If you don't then you are left in an unknown state.

Comment 10

[Gervase Markham [:gerv]]

Like Kevin says: it just says "no update available" for a second, then goes back to the original. I think the comment #7 solution is a good one.

(I can confirm this still happens on current Aurora.)

Gerv

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

QA thought : Would people know to reclick on "No Update Available" to recheck if they don't read this bug?  I believe it wouldn't be obvious and people will end up filing a bug on that itself because it doesn't say check for updates.

Perhaps we can lengthen the time that it states "no update available"?

Comment 13

[Michael Kohler [:mkohler]]

Any decision yet?

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

We are considering reworking the updater as a separate service in Android