Last Comment Bug 717492 - [New Tab Page] URL bar history pops up when pressing toolbar buttons
: [New Tab Page] URL bar history pops up when pressing toolbar buttons
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: Firefox 12
Assigned To: Tim Taubert [:ttaubert]
:
:
Mentors:
Depends on:
Blocks: 716538
  Show dependency treegraph
 
Reported: 2012-01-11 18:40 PST by Tim Taubert [:ttaubert]
Modified: 2012-01-28 06:20 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (1.16 KB, patch)
2012-01-12 06:45 PST, Tim Taubert [:ttaubert]
dao+bmo: review-
Details | Diff | Splinter Review
patch v2 (1.05 KB, patch)
2012-01-25 11:13 PST, Tim Taubert [:ttaubert]
dao+bmo: review+
Details | Diff | Splinter Review

Description Tim Taubert [:ttaubert] 2012-01-11 18:40:52 PST
STR:

1) Open a new tab with the New Tab Page
2) Make sure the URL bar has focus
3) Click a toolbar button (in the upper right)

Actual:

The Awesomebar pops up.

Expected:

The Awesomebar should not pop up.
Comment 1 Tim Taubert [:ttaubert] 2012-01-12 06:45:38 PST
Created attachment 588018 [details] [diff] [review]
patch v1

Calls urlbar.blur() on mousedown of a toolbar button to explicitly remove the url bar's focus.
Comment 2 Dão Gottwald [:dao] 2012-01-25 08:37:27 PST
Comment on attachment 588018 [details] [diff] [review]
patch v1

I don't think the new tab page should mess with random chrome elements. What prevents this bug from happening on ordinary web pages? Maybe steal focus by focusing the root / body element?
Comment 3 Tim Taubert [:ttaubert] 2012-01-25 11:13:56 PST
Created attachment 591554 [details] [diff] [review]
patch v2

(In reply to Dão Gottwald [:dao] from comment #2)
> I don't think the new tab page should mess with random chrome elements. What
> prevents this bug from happening on ordinary web pages?

about:newtab is the only 'real' web page with an empty url bar. That's why it happens.

> Maybe steal focus by focusing the root / body element?

Yes, that's *way* easier/better. Not sure why I didn't think of this...
Comment 4 Tim Taubert [:ttaubert] 2012-01-25 14:55:22 PST
https://hg.mozilla.org/integration/fx-team/rev/74b125f29e23
Comment 5 Tim Taubert [:ttaubert] 2012-01-25 23:59:34 PST
https://hg.mozilla.org/mozilla-central/rev/74b125f29e23
Comment 6 Tim Taubert [:ttaubert] 2012-01-26 10:02:33 PST
Backed out:

https://hg.mozilla.org/mozilla-central/rev/104bc7e10373
Comment 7 Tim Taubert [:ttaubert] 2012-01-27 08:11:28 PST
https://hg.mozilla.org/integration/fx-team/rev/ab6256b65403
Comment 8 Tim Taubert [:ttaubert] 2012-01-28 06:20:46 PST
https://hg.mozilla.org/mozilla-central/rev/ab6256b65403

Note You need to log in before you can comment on or make changes to this bug.