Closed Bug 717492 Opened 13 years ago Closed 13 years ago

[New Tab Page] URL bar history pops up when pressing toolbar buttons

Categories

(Firefox :: Tabbed Browser, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file, 1 obsolete file)

STR:

1) Open a new tab with the New Tab Page
2) Make sure the URL bar has focus
3) Click a toolbar button (in the upper right)

Actual:

The Awesomebar pops up.

Expected:

The Awesomebar should not pop up.
Attached patch patch v1 (obsolete) — Splinter Review
Calls urlbar.blur() on mousedown of a toolbar button to explicitly remove the url bar's focus.
Attachment #588018 - Flags: review?(dao)
Comment on attachment 588018 [details] [diff] [review]
patch v1

I don't think the new tab page should mess with random chrome elements. What prevents this bug from happening on ordinary web pages? Maybe steal focus by focusing the root / body element?
Attachment #588018 - Flags: review?(dao) → review-
Attached patch patch v2Splinter Review
(In reply to Dão Gottwald [:dao] from comment #2)
> I don't think the new tab page should mess with random chrome elements. What
> prevents this bug from happening on ordinary web pages?

about:newtab is the only 'real' web page with an empty url bar. That's why it happens.

> Maybe steal focus by focusing the root / body element?

Yes, that's *way* easier/better. Not sure why I didn't think of this...
Attachment #588018 - Attachment is obsolete: true
Attachment #591554 - Flags: review?(dao)
Attachment #591554 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/fx-team/rev/74b125f29e23
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/74b125f29e23
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Backed out:

https://hg.mozilla.org/mozilla-central/rev/104bc7e10373
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/ab6256b65403
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: