Last Comment Bug 717509 - IonMonkey: implement BoundsCheck on ARM
: IonMonkey: implement BoundsCheck on ARM
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: ARM Linux
: -- normal (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-11 19:54 PST by Marty Rosenberg [:mjrosenb]
Modified: 2012-01-30 16:06 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
implement bounds check, and fix a couple of exposed bugs (5.91 KB, patch)
2012-01-11 19:54 PST, Marty Rosenberg [:mjrosenb]
Jacob.Bramley: review+
Details | Diff | Splinter Review

Description Marty Rosenberg [:mjrosenb] 2012-01-11 19:54:24 PST
Created attachment 587929 [details] [diff] [review]
implement bounds check, and fix a couple of exposed bugs

Evidently, NYI's that are in LIR.cpp are actually things that I need to implement.
Comment 1 Jacob Bramley [:jbramley] 2012-01-12 10:01:15 PST
Comment on attachment 587929 [details] [diff] [review]
implement bounds check, and fix a couple of exposed bugs

Review of attachment 587929 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: js/src/ion/arm/CodeGenerator-arm.cpp
@@ -1239,2 @@
>          if (valueType == MIRType_Double) {
>              masm.ma_vstr(ToFloatRegister(value), base, index);

Didn't this get an uninitialized value warning from the compiler? Nice catch, anyway.

Note You need to log in before you can comment on or make changes to this bug.