Closed Bug 717509 Opened 12 years ago Closed 12 years ago

IonMonkey: implement BoundsCheck on ARM

Categories

(Core :: JavaScript Engine, defect)

ARM
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mjrosenb, Unassigned)

Details

Attachments

(1 file)

Evidently, NYI's that are in LIR.cpp are actually things that I need to implement.
Attachment #587929 - Flags: review?(Jacob.Bramley)
Comment on attachment 587929 [details] [diff] [review]
implement bounds check, and fix a couple of exposed bugs

Review of attachment 587929 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: js/src/ion/arm/CodeGenerator-arm.cpp
@@ -1239,2 @@
>          if (valueType == MIRType_Double) {
>              masm.ma_vstr(ToFloatRegister(value), base, index);

Didn't this get an uninitialized value warning from the compiler? Nice catch, anyway.
Attachment #587929 - Flags: review?(Jacob.Bramley) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.