Note: There are a few cases of duplicates in user autocompletion which are being worked on.

IonMonkey: implement BoundsCheck on ARM

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mjrosenb, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 587929 [details] [diff] [review]
implement bounds check, and fix a couple of exposed bugs

Evidently, NYI's that are in LIR.cpp are actually things that I need to implement.
Attachment #587929 - Flags: review?(Jacob.Bramley)
Comment on attachment 587929 [details] [diff] [review]
implement bounds check, and fix a couple of exposed bugs

Review of attachment 587929 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: js/src/ion/arm/CodeGenerator-arm.cpp
@@ -1239,2 @@
>          if (valueType == MIRType_Double) {
>              masm.ma_vstr(ToFloatRegister(value), base, index);

Didn't this get an uninitialized value warning from the compiler? Nice catch, anyway.
Attachment #587929 - Flags: review?(Jacob.Bramley) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.