FAIL_ON_WARNINGS in content/canvas/src

RESOLVED FIXED in mozilla12

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Created attachment 588013 [details] [diff] [review]
fix content/canvas/src warnings
Attachment #588013 - Flags: review?
(Assignee)

Comment 1

6 years ago
Created attachment 588014 [details] [diff] [review]
Fix unused-but-set warnings in content/html

I didn't feel like removing this rv altogether: it seems to contain some information about what we would want to check if we wanted to check for errors here, and the (void) rv serves as explicitly saying that we're not checking rv here.
Attachment #588014 - Flags: review?
(Assignee)

Comment 2

6 years ago
Created attachment 588015 [details] [diff] [review]
Fix cast-to-ptr-of-different-size warning in nsCheapSets

hg log is clueless about who owns this code (r1) so asking you again.
Attachment #588015 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #588013 - Flags: review? → review?(Ms2ger)
(Assignee)

Updated

6 years ago
Attachment #588014 - Flags: review? → review?(Ms2ger)
(Assignee)

Updated

6 years ago
Attachment #588015 - Flags: review? → review?(Ms2ger)
Comment on attachment 588013 [details] [diff] [review]
fix content/canvas/src warnings

>--- a/content/canvas/src/WebGLContext.cpp
>+++ b/content/canvas/src/WebGLContext.cpp
>+    (void) preferEGL;
>+    (void) useANGLE;

I'd prefer not doing the work to compute these if we aren't going to use them.

>--- a/content/canvas/src/WebGLContextGL.cpp
>+++ b/content/canvas/src/WebGLContextGL.cpp

What is the warning for the byteOffset changes?
Attachment #588013 - Flags: review?(Ms2ger)
Comment on attachment 588014 [details] [diff] [review]
Fix unused-but-set warnings in content/html

These are fixed in another bug
Attachment #588014 - Flags: review?(Ms2ger)
Comment on attachment 588015 [details] [diff] [review]
Fix cast-to-ptr-of-different-size warning in nsCheapSets

This too (bug 679832)
Attachment #588015 - Flags: review?(Ms2ger)
(Assignee)

Comment 6

6 years ago
Created attachment 588123 [details] [diff] [review]
fix content/canvas/src warnings

(In reply to Ms2ger from comment #3)
> Comment on attachment 588013 [details] [diff] [review]
> fix content/canvas/src warnings
> 
> >--- a/content/canvas/src/WebGLContext.cpp
> >+++ b/content/canvas/src/WebGLContext.cpp
> >+    (void) preferEGL;
> >+    (void) useANGLE;
> 
> I'd prefer not doing the work to compute these if we aren't going to use
> them.

OK, see new patch.

> 
> >--- a/content/canvas/src/WebGLContextGL.cpp
> >+++ b/content/canvas/src/WebGLContextGL.cpp
> 
> What is the warning for the byteOffset changes?

Cast to pointer from integer of different size.
Attachment #588013 - Attachment is obsolete: true
Attachment #588014 - Attachment is obsolete: true
Attachment #588015 - Attachment is obsolete: true
Attachment #588123 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #588123 - Flags: review? → review?(Ms2ger)
Comment on attachment 588123 [details] [diff] [review]
fix content/canvas/src warnings

>+#ifdef XP_WIN
>     // allow forcing GL and not EGL/ANGLE
>     if (PR_GetEnv("MOZ_WEBGL_FORCE_OPENGL")) {
>         preferEGL = false;
>         useANGLE = false;
>         useOpenGL = true;
>     }
>+#endif

Don't ifdef the useOpenGL assignment, please.
Attachment #588123 - Flags: review?(Ms2ger) → review+
(Assignee)

Comment 8

6 years ago
Why? useOpenGL is already initialized above.
It can be set to false in the previous block, no?
Ah yes, but then the only effect of that would be to circumvent blacklisting, and there exist much better ways to do that.

Actually, I don't really see the usefulness of this environment variable now that we seem to have prefs for everything. Jeff?
Agreed. By that virtue, why don't we eliminate the MOZ_WEBGL_PREFER_EGL EnvVar as well?
(Assignee)

Updated

6 years ago
Summary: FAIL_ON_WARNINGS in content/canvas/src, and misc warning fixes → FAIL_ON_WARNINGS in content/canvas/src
http://hg.mozilla.org/integration/mozilla-inbound/rev/5634697d0acd
Assignee: nobody → bjacob
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/5634697d0acd
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.