717600 - Maxlength attribute is ignored for typed characters with the vkb (even when composition string is committed)

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Keyboards and IME, defect, P4)

Description

[Martijn Wargers (dead)]

See first text input on http://miketaylr.com/pres/html5/forms2.html

Steps to reproduce:
- Tap on first text input, vkb comes up
- Type more than 6 characters in the text input

Expected result:
- No more text should appear than the first 6 characters

Actual result:
- All the text shows up that has been typed, even after the 6th character

With the context menu, the pasted text is cut off to 6 characters, so there it is not ignored.

Comment 1

[Mounir Lamouri (:mounir)]

I believe this is related to the editor.
Though, we are going to make that behavior the normal behavior with bug 613016.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is not a bug. The composition string must not be cut off by maxlength attribute because Japanese IME needs to be able to convert longer unconverted text to shorter converted text. (bug 98434) nsEditor cuts off when the composition string is committed.

Comment 3

[Martijn Wargers (dead)]

Not happening on the LG Optimus Black. The committed composition string is longer than 6 characters here.

Comment 4

[Martijn Wargers (dead)]

Attachment: Screenshot of bug

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Isn't the *committed* string shrunk to the maxlength? If so, it's a bug, but I'm not sure why I cannot reproduce it on desktop Fx. nsEditor does handle the maxlength attribute.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Here is the implementation:
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/text/nsTextEditRules.cpp#606

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Okay, I confirmed it. The committed string isn't shrunk to the maxlength on Android.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, that's strange, if typing without IME, maxlength does work fine.

Comment 9

[(no longer active)]

So, IsIMEComposing() return true here, right? <http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/text/nsTextEditRules.cpp#1195>  No wonder we don't truncate insertion then!

I don't see the code responsible for doing the truncation when committing...

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

cc'ing Alexp.  Maybe he might be able to get some input.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Committing string shouldn't have any information of clauses of composition string. When nsEditor receives such text event, nsEditor::mIsIMEComposing becomes false.

http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/base/nsEditor.cpp#4379
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/base/nsEditor.cpp#4349
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/text/nsPlaintextEditor.cpp#978

nsWindow for Android might set some clause information for commit event.
http://mxr.mozilla.org/mozilla-central/source/widget/android/nsWindow.cpp#1950

Comment 12

[(no longer active)]

I'm not sure if I understand comment 11.  What I was trying to say in comment 9 is that I think we should look at the maxlength property and truncate the insertion if needed when committing an IME transaction.  Do you agree?

Comment 13

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

latest build seems cannot reproduce.