Empty jsloader and jsloader\resource directories added to the Firefox 10.0b4 installer and thereby to the installation which do not get removed on uninstall

VERIFIED FIXED in mozilla15

Status

()

Core
Build Config
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: pauly, Assigned: gaston)

Tracking

10 Branch
mozilla15
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Steps to reproduce:
1. Install Firefox 10b4
2. Uninstall

Actual results:
Empty folder left: "c:\Program Files (x86)\Mozilla Firefox\jsloader\resource"

Expected results:
All data removed
Component: General → NSIS Installer
Product: Firefox → Toolkit
QA Contact: general → nsis.installer
Looks like there are empty directories being added in the beta build.

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/10.0b4-candidates/build1/win32/en-US/Firefox%20Setup%2010.0b4.exe

We could teach the installer to clean these sort of things up but it would be better to just not add empty / unused directories as we have always done.
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
QA Contact: nsis.installer → installer
Summary: Uninstalling Firefox doesn't clear data from Program Files → Empty jsloader and jsloader\resource directories added to the installer and thereby to the installation which do not get removed on uninstall
Summary: Empty jsloader and jsloader\resource directories added to the installer and thereby to the installation which do not get removed on uninstall → Empty jsloader and jsloader\resource directories added to the Firefox 10.0b4 installer and thereby to the installation which do not get removed on uninstall
They're also present in installers going all the way back to 8.0b1, so this would probably changed in the 6 weeks Fx8 was development on mozilla-central.
I think this was caused by bug 655678. I suspect that all that is needed is the removal of the jsloader dir along with its contents as the last action in
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#460
I wanted to mention previously that I seen this too but forgot.
Paul, can you confirm that this only happens on Windows 7 (as per the Platform field in this bug)?
(Reporter)

Comment 6

5 years ago
Same behavior on Win XP and Vista. But I would say this is reproducible on all Windows.
(In reply to Paul Silaghi [QA] from comment #6)
> Same behavior on Win XP and Vista. But I would say this is reproducible on
> all Windows.

...and what about Linux and Mac?
(Reporter)

Comment 8

5 years ago
There is no installer on Mac and Linux
The jsloader dirs are actually present in the linux tarballs (32 and 64bit builds), but not included in the mac dmg.
(Assignee)

Comment 10

5 years ago
Starting with firefox 13.0beta i'm also seeing an empty jssubloader/185/resource/ dir, along jsloader/resource/. This is after 'make install' when building from a source tarball on OpenBSD (so, a unix platform). jsloader/resource appeared between 7.0.1 and 8.0.1 and is present in releases too, not only betas.
(Assignee)

Comment 11

5 years ago
Created attachment 622672 [details] [diff] [review]
Remove empty jsloader/jssubloader dirs at the end of generate_cache

This patch seems to fix the issue for me, i've generated a package through make package which didnt contain jsloader nor jssubloader dirs. Only tested on OpenBSD, so maybe worth a try run ?
Attachment #622672 - Flags: review?(mh+mozilla)
Attachment #622672 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a502079098
Target Milestone: --- → Firefox 15
Assignee: nobody → landry
Component: Installer → Build Config
Product: Firefox → Core
QA Contact: installer → build-config
Target Milestone: Firefox 15 → mozilla15
https://hg.mozilla.org/mozilla-central/rev/a0a502079098
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 14

5 years ago
Verified fixed on FF 15.0a1 (2012-05-15) on Win 7, Ubuntu 12.04 and Mac OS 10.6. No more jsloader dirs on FF packages.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 15

5 years ago
Is it worth backporting to aurora/beta ?
A webapprt directory is now left in the installation folder when uninstalling Firefox 15.0a2. What could cause this?
> A webapprt directory is now left in the installation folder when
> uninstalling Firefox 15.0a2. What could cause this?

The web app work introduced that regression.  Details can be found here: Bug 757978
You need to log in before you can comment on or make changes to this bug.