717674 - Wrong selection color used on autocomplete entries on ICS

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (01/12)

See screenshot.

ICS has the baby blue on other controls, Gingerbread has the orange.

--
Nightly (01/12)
Nexus S (Android 4.0.3)

Comment 1

[Tony Chung [:tchung]]

Attachment: screenshot on 1/13 Galaxy Nexus

im running the 1/13 nightly on Galaxy Nexus, Android 4.0.2.

i actually dont get any highlights from the same testcase

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch fixes the ICS version with the Holo theme.
I believe the minHeight of these items should be a bit bigger. The touch target area is very less ( < 9mm as Window Phone recommends -- only good thing in their UX design ;) ).

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/266cd6aa74dc

Comment 4

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/266cd6aa74dc

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Sriram, be sure to request approval for aurora?

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 591320 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
The list will have old (gingerbread) orange color instead of ICS's blue color for the list.

Testing completed (on m-c, etc.): Landed on m-c on 01/28

Risk to taking this patch (and alternatives if risky):
The risk is very low. The color defaults to orange on devices. It's better to have it in blue to have the device's list feel.