PerfConfigurator.py --develop sets the resultsURL to an empty space if resultsURL is '' (a False value): http://hg.mozilla.org/build/talos/file/2b0122185abd/talos/PerfConfigurator.py#l487 However, no one can recall why this is done. If resultsURL is '', the intention is that you don't put the results to a graphserver: http://hg.mozilla.org/build/talos/file/2b0122185abd/talos/run_tests.py#l557 So why the ' ', which is *not* a false value?
I've looked into this a bit, here's what I've found: Setting resultsURL to a single space produces this: #comment out next line to disable send to graph server results_url: develop: True When run_tests reads this file, results_url is set to "None," and results are not sent to the graph server. If resultsURL is not set to the blank space, PerfConfigurator produces the following: #comment out next line to disable send to graph server #results_url: 'http://url.of.graphserver/bulk.cgi' develop: True I am still able to run tests ok in this case. Perhaps an older version of run_tests would have produced a key error?
I suggest removing the ' ' hack and clean it up!
Created attachment 589697 [details] [diff] [review] Bug 717693 - Figure out why --develop sets resultsURL to an empty space and fix it Simply removes the two lines that re-set resultsURL to a whitespace character. As noted, this does not appear to impact the tests.
Comment on attachment 589697 [details] [diff] [review] Bug 717693 - Figure out why --develop sets resultsURL to an empty space and fix it nice :)