717725 - sutagent 'exec' waits for 'am instrument...' command to finish instead of letting it run in the background

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In order to run robotium, we need to run 'am instrument <params>'.  When running this via sutagent exec, we block on the call.  Normally for exec, we don't block on org.mozilla.fennec or similar commands.

We can work around this in the devicemanager and python harness code, but it would be nice to fix this in sutagent.

For example, here is code that makes it work by hacking the harnesses:
--- a/build/mobile/remoteautomation.py	Thu Jan 12 15:34:16 2012 -0500
+++ b/build/mobile/remoteautomation.py	Thu Jan 12 15:34:36 2012 -0500
@@ -156,7 +156,10 @@
             self.stdoutlen = 0
             self.proc = dm.launchProcess(cmd, stdout, cwd, env, True)
             if (self.proc is None):
-              raise Exception("unable to launch process")
+              if cmd[0] == 'am':
+                self.proc = stdout
+              else:
+                raise Exception("unable to launch process")
             exepath = cmd[0]
             name = exepath.split('/')[-1]
             self.procName = name

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: allow 'am' commands to execute and wait (1.0)

Patch to do my little hack mentioned in my comments.  In discussing on IRC with :gbrown, there are similar issues while running xpcshell tests via SUT agent and it would be nice to solve this in a bigger picture.

For the sake of getting things going, this patch will allow us to run end to end on SUT agent once it is landed.  A better solution in the near term is to resolve the launching (probably a change to SUTAgent) and work on rolling out an update to the tegras when we get a chance.

Comment 2

[Mozilla RelEng Bot]

Try run for 8b767bc75058 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=8b767bc75058
Results (out of 29 total builds):
    success: 23
    warnings: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-8b767bc75058

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

4 warnings are ignored tests, and the other 2 are random oranges.

Comment 4

[Geoff Brown [:gbrown]]

Comment on attachment 588279 [details] [diff] [review]
allow 'am' commands to execute and wait (1.0)

Review of attachment 588279 [details] [diff] [review]:
-----------------------------------------------------------------

Seems harmless!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks Geoff, we will land this today and work on defining a better solution.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf46df6a1fd9

Comment 7

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/mozilla-central/rev/bf46df6a1fd9