Fix int64 types usage in js/xpconnect

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

Trunk
mozilla12
x86
OpenBSD
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Followup to bug #714264, m-c now fails to build on OpenBSD with :
js/xpconnect/src/XPCJSRuntime.cpp:1881:
error: invalid conversion from 'PRInt64*' to 'int64_t*'

patch incoming fixing that issue (ie add a static_cast<int64_t*>(n) at the offending call, as it was done in the same call present in dom/workers/WorkerPrivate.cpp
(Assignee)

Comment 1

5 years ago
Created attachment 588163 [details] [diff] [review]
Fix int64 types breakage on OpenBSD

static_cast wasn't enough, so here's the patch with a "regular" cast. 
error: invalid static_cast from type 'PRInt64*' to type 'int64_t*'

(yeah, i've got to check what type is PRInt64...)
Assignee: general → landry
Attachment #588163 - Flags: review?(Ms2ger)
(Assignee)

Comment 2

5 years ago
Created attachment 588167 [details] [diff] [review]
Fix int64 types breakage on OpenBSD

And as pointed out by waldo on IRC, reinterpret_cast<> is the way to go here.
Attachment #588163 - Attachment is obsolete: true
Attachment #588163 - Flags: review?(Ms2ger)
Attachment #588167 - Flags: review?(Ms2ger)
Comment on attachment 588167 [details] [diff] [review]
Fix int64 types breakage on OpenBSD

Thanks, and sorry for breaking you.
Attachment #588167 - Flags: review?(Ms2ger) → review+
(Assignee)

Comment 4

5 years ago
Np, that increases my karma :)
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/821b2b0daf21
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/821b2b0daf21
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Depends on: 634793
You need to log in before you can comment on or make changes to this bug.