717733 - Fix int64 types usage in js/xpconnect

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Landry Breuil (:gaston)]

Followup to bug #714264, m-c now fails to build on OpenBSD with :
js/xpconnect/src/XPCJSRuntime.cpp:1881:
error: invalid conversion from 'PRInt64*' to 'int64_t*'

patch incoming fixing that issue (ie add a static_cast<int64_t*>(n) at the offending call, as it was done in the same call present in dom/workers/WorkerPrivate.cpp

Comment 1

[Landry Breuil (:gaston)]

Attachment: Fix int64 types breakage on OpenBSD

static_cast wasn't enough, so here's the patch with a "regular" cast. 
error: invalid static_cast from type 'PRInt64*' to type 'int64_t*'

(yeah, i've got to check what type is PRInt64...)

Comment 2

[Landry Breuil (:gaston)]

Attachment: Fix int64 types breakage on OpenBSD

And as pointed out by waldo on IRC, reinterpret_cast<> is the way to go here.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 588167 [details] [diff] [review]
Fix int64 types breakage on OpenBSD

Thanks, and sorry for breaking you.

Comment 4

[Landry Breuil (:gaston)]

Np, that increases my karma :)

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/821b2b0daf21

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/821b2b0daf21