717755 - 2012-01-12 14:11:13 -08:00 --- error: [5xx Error] File: application/libraries/drivers/Database/Pgsql.php; Line: 74; Message: pg_query(): Query failed: ERROR: OFFSET must not be negative

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://crash-stats.allizom.org/report/list?reason_type=contains&range_unit=days&query_search=signature&query_type=contains&process_type=any&version=Firefox%253A9.0.1&hang_type=any&signature=EMPTY%253A%2520no%2520crashing%2520thread%2520identified%253B%2520corrupt%2520dump&date=2012-01-11&page=a%3Benv&range_value=28 yields the following:

2012-01-12 14:11:13 -08:00 --- error: [5xx Error] File: application/libraries/drivers/Database/Pgsql.php; Line: 74; Message: pg_query(): Query failed: ERROR:  OFFSET must not be negative

FROM   reports LEFT OUTER JOIN  reports_duplicates ON reports.uuid = reports_duplicates.uuid WHERE  reports.signature = 'EMPTY%3A%20no%20crashing%20thread%20identified%3B%20corrupt%20dump' AND ((reports.product = 'Firefox%3A9.0.1')) AND reports.date_processed BETWEEN date_trunc('day', (TIMESTAMPTZ '2012-01-11' - INTERVAL '28 days' )) AND '2012-01-11' ORDER BY reports.date_processed DESC  LIMIT ? OFFSET ?

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

https://crash-stats.allizom.org/report/list?reason_type=contains&range_unit=days&query_search=signature&query_type=contains&process_type=any&version=Firefox%253A9.0.1&hang_type=any&signature=EMPTY%253A%2520no%2520crashing%2520thread%2520identified%253B%2520corrupt%2520dump&date=2012-01-11&page=http%3A%2F%2Fwww.google.com%2F&range_value=28 also repros the same exception, for extra verification.

Comment 2

[[:jberkus] Josh Berkus]

Note:  this is not a regression.   This is broken on production as well.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to [:jberkus] Josh Berkus from comment #2)
> Note:  this is not a regression.   This is broken on production as well.

Bumping to 2.4.1 since it's not a regression (the plan is to move this to use the search service in 2.4.1 anyway and throw away this code which is full of bugs and other fail)

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

I believe this is a duplicate of bug 716750. It will be fixed in 2.4.1 with bug 678642.

Comment 5

[Matt Brandt [:mbrandt]]

Verified duplicate of bug 716750.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

This is actually not a duplicate of bug 716750. The problem here is that those two URLs are bad, they both contain an incorrect version number without any ":" character. I fixed that. 

There is a second problem with the URL of comment 2: Kohana is unable to parse it because of the ``page`` parameter, which here contains "http://www.google.com/". This is clearly due to a malformed URL, and I suspect you did not find this link on the website? I don't really know how to fix this, and even if we should fix this: this seems to be a user error to me. Thoughts?

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

Opened pull request https://github.com/mozilla/socorro/pull/304

In both cases the URL is incorrect, for a reason that we ignore. The first problem (the version parameter not being what it is expected to be) is fixed by the pull request. However, the second problem, caused by the URL in the page parameter, is due to an error in Kohana, and thus we decided to not fix it. 

I believe it is impossible that those two URLs where linked from crash-stats.m.o. Not fixing doesn't seem to be a real problem for our users.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/76cb5542d010137ba608d7ee20ca65320381e2e0
Merge pull request #304 from AdrianGaudebert/717755-fix-report-list-500-error

Fixes bug 717755 - Check there is a version number before using it.

Comment 9

[Matt Brandt [:mbrandt]]

QA verified on dev. Thanks adrian ... stephend nice find!

Comment 10

[[github robot]]

Commits pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b64138f113cf94bef21a17ba9e52e31589f7e9d8
Fixes bug 717755 - Check a version is correctly formated before using it. Fix by Brandon Savage.

https://github.com/mozilla/socorro/commit/b30e722a4b7c0da36dcda01c8175b8f67edc74ef
Merge pull request #306 from rhelmer/stage

Fixes bug 717755 - Check a version is correctly formated before using it...

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.allizom.org/report/list?reason_type=contains&range_unit=days&query_search=signature&query_type=contains&process_type=any&version=Firefox%253A9.0.1&hang_type=any&signature=EMPTY%253A%2520no%2520crashing%2520thread%2520identified%253B%2520corrupt%2520dump&date=2012-01-11&page=a%3Benv&range_value=28