Consider removing the viewport bias

VERIFIED FIXED in Firefox 14

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: pcwalton, Assigned: kats)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 14
ARM
Android
Points:
---

Firefox Tracking Flags

(blocking-fennec1.0 beta+, fennec-)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 588208 [details] [diff] [review]
Proposed patch.

The viewport bias is causing problems for me. Issues are:
* When placing a finger down immediately after a fling, there's often checkerboarding visible when panning opposite to the fling (which never goes away since we don't render when a finger is down).
* When flinging and reversing direction, we get immediate checkerboarding since we buffered in the wrong direction.

These two cases happen more than I suspected, and I think the tiling work will make the bias unnecessary. I tried removing the bias, as in this patch, and it seemed better.
Attachment #588208 - Flags: review?(chrislord.net)
(Reporter)

Updated

6 years ago
OS: Mac OS X → Android
Hardware: x86 → ARM
(Reporter)

Updated

6 years ago
Assignee: nobody → pwalton

Comment 1

6 years ago
Comment on attachment 588208 [details] [diff] [review]
Proposed patch.

Review of attachment 588208 [details] [diff] [review]:
-----------------------------------------------------------------

Tiling will make this unnecessary, but I don't think it should be applied before then. r+ if this depends on a tiling patch going in first, but r- on its own.

These problems could be helped before tiling by making the bias only apply once a threshold distance has been surpassed. This should catch the case of fast scrolling (which this helps) and slow scrolling (which this doesn't, much).
Attachment #588208 - Flags: review?(chrislord.net) → review-

Comment 2

6 years ago
tracking so that we can a decision if we need this or not.
tracking-fennec: --- → 11+

Updated

6 years ago
tracking-fennec: 11+ → -
The viewport bias wasn't being used in maple, so I ripped it out.

https://hg.mozilla.org/projects/maple/rev/870ec775f08c
Assignee: pwalton → bugmail.mozilla
Keywords: fennecnative-betablocker

Updated

6 years ago
Priority: -- → P1
Closing this as it's fixed in maple with the above changeset.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
blocking-fennec1.0: --- → beta+
This is not reproducible on the latest nightly:
Nightly 14.0a1 (2012-04-11) 20120411030716
Galaxy SII (Android 2.3.4)

Verifying.
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.