Last Comment Bug 717862 - Error: Goto dbus_done bypasses a variable (or an exception) initialization.
: Error: Goto dbus_done bypasses a variable (or an exception) initialization.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All Solaris
: -- normal (vote)
: mozilla12
Assigned To: Ginn Chen
:
Mentors:
Depends on:
Blocks: 693343
  Show dependency treegraph
 
Reported: 2012-01-12 22:45 PST by Ginn Chen
Modified: 2012-01-16 19:35 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.15 KB, patch)
2012-01-12 22:46 PST, Ginn Chen
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description Ginn Chen 2012-01-12 22:45:37 PST
accessible/src/atk/nsApplicationAccessibleWrap.cpp, line 904:

903   if (!message)
904     goto dbus_done;
905 
906   static const char* iface = "org.a11y.Status";
907   static const char* member = "IsEnabled";
908   dbus_message_append_args(message, DBUS_TYPE_STRING, &iface,
909                            DBUS_TYPE_STRING, &member, DBUS_TYPE_INVALID);
910   dbus_connection_send_with_reply(bus, message, &sPendingCall, 1000);
911   dbus_message_unref(message);
912 
913 dbus_done:
914   dbus_connection_unref(bus);
Comment 1 Ginn Chen 2012-01-12 22:46:28 PST
Created attachment 588320 [details] [diff] [review]
patch
Comment 3 Justin Wood (:Callek) 2012-01-16 19:35:32 PST
https://hg.mozilla.org/mozilla-central/rev/f64609a21235

Note You need to log in before you can comment on or make changes to this bug.