Closed Bug 717862 Opened 8 years ago Closed 8 years ago

Error: Goto dbus_done bypasses a variable (or an exception) initialization.

Categories

(Core :: Disability Access APIs, defect)

All
Solaris
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

Attachments

(1 file)

accessible/src/atk/nsApplicationAccessibleWrap.cpp, line 904:

903   if (!message)
904     goto dbus_done;
905 
906   static const char* iface = "org.a11y.Status";
907   static const char* member = "IsEnabled";
908   dbus_message_append_args(message, DBUS_TYPE_STRING, &iface,
909                            DBUS_TYPE_STRING, &member, DBUS_TYPE_INVALID);
910   dbus_connection_send_with_reply(bus, message, &sPendingCall, 1000);
911   dbus_message_unref(message);
912 
913 dbus_done:
914   dbus_connection_unref(bus);
Attached patch patchSplinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #588320 - Flags: review?(trev.saunders)
Attachment #588320 - Flags: review?(trev.saunders) → review+
https://hg.mozilla.org/mozilla-central/rev/f64609a21235
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.