Error: Goto dbus_done bypasses a variable (or an exception) initialization.

RESOLVED FIXED in mozilla12

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

unspecified
mozilla12
All
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
accessible/src/atk/nsApplicationAccessibleWrap.cpp, line 904:

903   if (!message)
904     goto dbus_done;
905 
906   static const char* iface = "org.a11y.Status";
907   static const char* member = "IsEnabled";
908   dbus_message_append_args(message, DBUS_TYPE_STRING, &iface,
909                            DBUS_TYPE_STRING, &member, DBUS_TYPE_INVALID);
910   dbus_connection_send_with_reply(bus, message, &sPendingCall, 1000);
911   dbus_message_unref(message);
912 
913 dbus_done:
914   dbus_connection_unref(bus);
(Assignee)

Comment 1

6 years ago
Created attachment 588320 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #588320 - Flags: review?(trev.saunders)
Attachment #588320 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f64609a21235
https://hg.mozilla.org/mozilla-central/rev/f64609a21235
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.