Closed Bug 717951 Opened 11 years ago Closed 11 years ago

CrashReporter::AppendAppNotesToCrashReport is not thread-safe

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: ajuma, Assigned: ajuma)

References

Details

Attachments

(1 file)

Allow AppendAppNotesToCrashReport to be called from off the main thread in the chrome process
4.95 KB, patch
ted
: review+
Details | Diff | Splinter Review 
With off-main-thread-compositing, ScopedGfxFeatureReporter (which calls AppendAppNotesToCrashReport) will be used on the compositor thread. However, ApppendAppNotesToCrashReport isn't thread-safe, since it accesses the global notesField string without any locking.
It's never been intended to be threadsafe, so if you need this behavior you'll have to fix it yourself. It shouldn't be perf-critical, so I don't think the locking overhead will hurt.
Assignee: nobody → ajuma
This adds locking to prevent concurrent access to notesField.
Attachment #589623 - Flags: review?(ted.mielczarek)
Attachment #589623 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cf430a5716c
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/4cf430a5716c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
No longer blocks: omtc
Blocks: omtc
You need to log in before you can comment on or make changes to this bug.