Closed Bug 717951 Opened 8 years ago Closed 8 years ago
Reporter::Append App Notes To Crash Report is not thread-safe
With off-main-thread-compositing, ScopedGfxFeatureReporter (which calls AppendAppNotesToCrashReport) will be used on the compositor thread. However, ApppendAppNotesToCrashReport isn't thread-safe, since it accesses the global notesField string without any locking.
It's never been intended to be threadsafe, so if you need this behavior you'll have to fix it yourself. It shouldn't be perf-critical, so I don't think the locking overhead will hurt.
This adds locking to prevent concurrent access to notesField.
Attachment #589623 - Flags: review?(ted.mielczarek)
Attachment #589623 - Flags: review?(ted.mielczarek) → review+
Target Milestone: --- → mozilla12
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.