Last Comment Bug 718001 - Wifi: Automatically run dhcp when we connect to a network
: Wifi: Automatically run dhcp when we connect to a network
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla12
Assigned To: Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: b2g-wifi
  Show dependency treegraph
 
Reported: 2012-01-13 11:07 PST by Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
Modified: 2012-01-16 19:43 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (4.92 KB, patch)
2012-01-13 11:07 PST, Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
gal: review+
mrbkap: checkin+
Details | Diff | Splinter Review

Description Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2012-01-13 11:07:41 PST
Created attachment 588471 [details] [diff] [review]
Patch

Right now, nsWifiWorker.js only runs DHCP as part of a chain of calls when we enable a network. Instead of doing that, we should try to run DHCP when wpa_supplicant tells us that it connected to a network. That way, networks that were joined automatically should get dhcp/dns love.
Comment 1 Andreas Gal :gal 2012-01-13 11:29:38 PST
Comment on attachment 588471 [details] [diff] [review]
Patch

Pure awesomeness. Why the _ on onconnected?
Comment 2 Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2012-01-16 08:01:25 PST
Comment on attachment 588471 [details] [diff] [review]
Patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d2f21cfac9c (without the _)
Comment 3 Justin Wood (:Callek) 2012-01-16 19:43:57 PST
https://hg.mozilla.org/mozilla-central/rev/0d2f21cfac9c

Note You need to log in before you can comment on or make changes to this bug.