Closed
Bug 718111
Opened 12 years ago
Closed 12 years ago
Unable to search for beta releases
Categories
(Socorro Graveyard :: Middleware, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2.4.2
People
(Reporter: mbrandt, Assigned: adrian)
Details
Steps to reproduce: 1. find a known crash signature for a beta release of Firefox https://crash-stats.allizom.org/report/list?range_value=7&range_unit=days&date=2012-01-10&signature=hang%20|%20mozilla%3A%3Aplugins%3A%3APPluginInstanceParent%3A%3ACallPBrowserStreamConstructor%28mozilla%3A%3Aplugins%3A%3APBrowserStreamParent*%2C%20nsCString%20const%26%2C%20unsigned%20int%20const%26%2C%20unsigned%20int%20const%26%2C%20mozilla%3A%3Aplugins%3A%3APStreamNotifyParent*%2C%20nsCString%20const%26%2C%20nsCString%20const...&version=Firefox%3A9.0.1%28beta%29 2.Searching for this signature doesn't return results: hang | mozilla::plugins::PPluginInstanceParent::CallPBrowserStreamConstructor(mozilla::plugins::PBrowserStreamParent*, nsCString const&, unsigned int const&, unsigned int const&, mozilla::plugins::PStreamNotifyParent*, nsCString const&, nsCString const Actual GET request: https://crash-stats.allizom.org/query/query?product=Firefox&version=Firefox%3A9.0.1%28beta%29&range_value=1&range_unit=weeks&date=01%2F13%2F2012+15%3A48%3A21&query_search=signature&query_type=contains&query=hang+|+mozilla%3A%3Aplugins%3A%3APPluginInstanceParent%3A%3ACallPBrowserStreamConstructor%28mozilla%3A%3Aplugins%3A%3APBrowserStreamParent*%2C+nsCString+const%26%2C+unsigned+int+const%26%2C+unsigned+int+const%26%2C+mozilla%3A%3Aplugins%3A%3APStreamNotifyParent*%2C+nsCString+const%26%2C+nsCString+const&reason=&build_id=&process_type=content&hang_type=any&do_query=1 Generates this sql: SELECT r.signature, count(r.id) as total, count(CASE WHEN (r.os_name = E'Windows NT') THEN 1 END) AS is_windows, count(CASE WHEN (r.os_name = E'Mac OS X') THEN 1 END) AS is_mac, count(CASE WHEN (r.os_name = E'Linux') THEN 1 END) AS is_linux, SUM (CASE WHEN r.hangid IS NULL THEN 0 ELSE 1 END) AS numhang, SUM (CASE WHEN r.process_type='plugin' THEN 1ELSE 0 END) as numplugin, SUM (CASE WHEN r.process_type='content' THEN 1ELSE 0 END) as numcontent FROM reports rWHERE r.date_processed BETWEEN '2012-01-06T15:48:21+00:00' AND '2012-01-13T15:48:21+00:00'AND r.signature LIKE E'%hang | mozilla::plugins::PPluginInstanceParent::CallPBrowserStreamConstructor(mozilla::plugins::PBrowserStreamParent*, nsCString const&, unsigned int const&, unsigned int const&, mozilla::plugins::PStreamNotifyParent*, nsCString const&, nsCString const%' AND (r.product=E'Firefox') AND ((r.product=E'Firefox' AND r.release_channel NOT IN ('nightly', 'aurora', 'beta') AND r.version=E'9.0.1(beta)')) AND r.process_type = 'content' GROUP BY r.signature ORDER BY total DESC LIMIT 100 OFFSET 0
Comment 1•12 years ago
|
||
If this is only for the "(beta)" ones, this isn't really high priority because since shortly after we shipped support for this, we don't actually have release builds being shipped to the beta channel any more. If any crashes actually end up in those buckets right now, they are from people who have basically unsupported build+channel combinations and ones they don't end up with automatically.
Comment 2•12 years ago
|
||
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #1) > If this is only for the "(beta)" ones, this isn't really high priority > because since shortly after we shipped support for this, we don't actually > have release builds being shipped to the beta channel any more. If any > crashes actually end up in those buckets right now, they are from people who > have basically unsupported build+channel combinations and ones they don't > end up with automatically. Thanks, this is good to know.. I think we should simply remove this feature if it's no longer used. In case we do need to fix this, the bug appears to be in search - we need to look up the buildids as we do for other betas, "9.0.1(beta)" will never be a literal version number in the reports table: SELECT r.signature, count(r.id) as total, count(CASE WHEN (r.os_name = E'Windows NT') THEN 1 END) AS is_windows, count(CASE WHEN (r.os_name = E'Mac OS X') THEN 1 END) AS is_mac, count(CASE WHEN (r.os_name = E'Linux') THEN 1 END) AS is_linux, SUM (CASE WHEN r.hangid IS NULL THEN 0 ELSE 1 END) AS numhang,' SUM (CASE WHEN r.process_type='plugin' THEN 1ELSE 0 END) as numplugin, SUM (CASE WHEN r.process_type='content' THEN 1ELSE 0 END) as numcontent FROM reports r WHERE r.date_processed BETWEEN '2012-01-06T15:48:21+00:00' AND '2012-01-13T15:48:21+00:00'AND r.signature LIKE E'%hang | mozilla::plugins::PPluginInstanceParent::CallPBrowserStreamConstructor(mozilla::plugins::PBrowserStreamParent*, nsCString const&, unsigned int const&, unsigned int const&, mozilla::plugins::PStreamNotifyParent*, nsCString const&, nsCString const%' AND (r.product=E'Firefox') AND ( (r.product=E'Firefox' AND r.release_channel NOT IN ('nightly', 'aurora', 'beta') AND r.version=E'9.0.1(beta)')) AND r.process_type = 'content' GROUP BY r.signature ORDER BY total DESC LIMIT 100 OFFSET 0
Comment 3•12 years ago
|
||
I think this will have to wait for the next release or so - assigning to search master Adrian.
Assignee: nobody → adrian
Severity: major → normal
Target Milestone: 2.4.1 → 2.4.2
Assignee | ||
Comment 4•12 years ago
|
||
This was a simple problem caused by release channel being sometimes 'Beta' and other times 'beta' in the DB. I opened pull request https://github.com/mozilla/socorro/pull/329 to solve that problem and allow '(beta)' versions to be searched for.
Comment 5•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/07276af5a614d5c2c97960e9076d638258e7789e Fixes bug 718111 - Compare release_channel in lower case. https://github.com/mozilla/socorro/commit/d1f265f94859c56b3abad72cfebfd06676b7a078 Merge pull request #329 from AdrianGaudebert/718111-search-beta Fixes bug 718111 - Compare release_channel in lower case.
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•12 years ago
|
||
Steps to QA ----------- 1. Go to advanced search and run a search using product=Firefox and version=9.0.1(beta) 2. Verify that you see some results 3. Click on a signature and verify that you see the same number of total crashes in the Reports tab. 4. Start again for any version containing (beta) and verify you get results And 1. Click on the links in comment 1 and verify you get results.
Reporter | ||
Comment 7•12 years ago
|
||
QA verified on dev. Thx for the steps to reproduce in comment 6. Also verified comment 0 no longer fails.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Socorro → Socorro Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•