718159 - sessionstore prefs not in about:support

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Chris Ilias [:cilias]]

STR:
1. Go to about:config and set browser.sessionstore.max_resumed_crashes to 0.
2. Go to about:support.

Result:
browser.sessionstore.max_resumed_crashes is not listed under "Modified Preferences". 

Expected result:
browser.sessionstore.max_resumed_crashes should be listed under "Modified Preferences". 

I also tried it with browser.sessionstore.resume_from_crash, so assume it applies to all sessionstore prefs.

Tested on Mozilla/5.0 (Windows NT 5.1; rv:12.0a1) Gecko/20120113 Firefox/12.0a1

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch addind browser.sessionstore. to the whitelist of modified preferences to show

This patch adds browser.sessionstore. to the whitelist of preferences which will be shown in about:support if they have been modified.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 594471 [details] [diff] [review]
patch addind browser.sessionstore. to the whitelist of modified preferences to show

Paul can decide if it makes sense to include all of these.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 594471 [details] [diff] [review]
patch addind browser.sessionstore. to the whitelist of modified preferences to show

Since only the modified ones get included and they are often the cause of unexpected issues, I see no reason not to add them all.

Comment 4

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/803d5de3ced3

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/803d5de3ced3

Comment 6

[Chris Ilias [:cilias]]

Verified with:
Mozilla/5.0 (Windows NT 5.1; rv:13.0a1) Gecko/20120210 Firefox/13.0a1 BuildID:20120210031150

Thanks!