718182 - Use on Aero inverted icons

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

After landing of Bug 715495 the toolbar-buttons #lightning-button-calendar and #lightning-button-tasks would be messed. Also should the buttons on the tabbar look the same as the TB buttons.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: inverted icons patch

Patch adding the inverted icons and also rearranging the styles in the files so the Aero definitions don't have to overwrite the XP definitions.

Andreas: I've put initial icons. Feel free to make better icons.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Patch in action

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 588626 [details] [diff] [review]
inverted icons patch

I may have missed this, but where is the win-classic version of lightning.css loaded?

r=philipp aside from that

Comment 4

[Richard Marti (:Paenglab)]

It's loaded through calendar/lightning/themes/winstripe/lightning.css with @import url(chrome://calendar-windows/skin/lightning.css).

Depending if it's XP or Vista/Win7 it loads win-classic/lightning.css or win-aero/lightning.css.

It was introduced with Bug 684518. win-classic/lightning.css was empty to not make the patch more complex. Now I cleaned the button rules a bit and moved them to specific files so the Aero rules don't have to overwrite the XP rules.

Comment 5

[Andreas Nilsson (:andreasn)]

Comment on attachment 588626 [details] [diff] [review]
inverted icons patch

In general works great! The icons seems to move a bit when pressed and I want to do some small edits to the graphics, so marking as ui-r minus for now.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: inverted icons patch v2

Patch fixing the icon moving on pressing them.

Carrying over the review states from previous patch.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: inverted icons patch v3

I've only changed the license block in the new file calendar/base/themes/winstripe/win-classic/lightning.css

Andreas: had you the time to do the small edits to the graphics?

Comment 8

[Andreas Nilsson (:andreasn)]

Attachment: patch v4

Haven't tried in action yet, so not marking v3 as obsolete quite yet.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: inverted icons patch v5

Andreas, the calendar icon seemed to be too transparent. I gave the white parts the same white from task icon.

I let patch 4 open until you decide what looks better.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: Comparison, on top v4 on bottom v5

Comment 11

[Andreas Nilsson (:andreasn)]

(In reply to Richard Marti [:paenglab] from comment #10)
> Created attachment 591204 [details]
> Comparison, on top v4 on bottom v5

Yup, the white parts got the wrong transparency there!

Comment 12

[Richard Marti (:Paenglab)]

Comment on attachment 591203 [details] [diff] [review]
inverted icons patch v5

Okay, then I'm asking on v5 for ui-r.

Setting r+ from v1

Comment 13

[Andreas Nilsson (:andreasn)]

Comment on attachment 591203 [details] [diff] [review]
inverted icons patch v5

Yeah, looks good.
ui-r+

Comment 14

[Richard Marti (:Paenglab)]

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/dc8b1860f835>