Closed Bug 718184 Opened 11 years ago Closed 11 years ago

Bug 618353 reduced the space to the right of the Window controls

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: valeriopetroni, Unassigned)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Build ID: 20120111092507
Blocks: 618353
Component: Untriaged → Widget: Win32
Product: Firefox → Core
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached image border 1px smaller
with the patch of Bug 618353, the window border is 1px smaller than that of a native windows so a good compromise to make the problem less visible would be to increase the window border of 1px in Bug 618353
We don't control the positioning of these controls. :/
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
In Thunderbird, where the titlebar is NOT being drawn into, the buttons have the same distance from the edge of the window as other programs, say Widows Explorer.  

But, in Firefox, where drawing in the titlebar IS done, the buttons have little space from the edge of the window.  It looks really odd.

In fairness, the Firefox buttons have at least one extra pixel of space than how Chrome does it.  :D

Is there no way to add a little margin or padding to the caption buttons to push it more into "where they belong"?
On DWM (glass) desktops, unless we want to remove the default caption buttons and draw something custom (like Chrome) the positioning is handled by Windows. It would be easier to move the Fx button so that it matches I would think.
QA Contact: untriaged → win32
Duplicate of this bug: 903989
Duplicate of this bug: 940070
Duplicate of this bug: 1005656
(In reply to Jim Mathies [:jimm] from comment #2)
> We don't control the positioning of these controls. :/

Looks like dpJudas has found the cause of the 1px offset:

http://www.osnews.com/comments/27705#comment_587976 :
> Speaking of evidence, I just managed to get my test application to misbehave
> in the same way as Firefox is doing. If my test program adjusts the client
> rect as part of the WM_NCCALCSIZE(wParam=false) I get the same bug. Seems
> toying around with this value causes the DWM window frame to offset buttons
> incorrectly in a weird way.
Summary: Bug 618353 reduce the space to the right of the Window controls → Bug 618353 reduced the space to the right of the Window controls
Duplicate of this bug: 1002928
You need to log in before you can comment on or make changes to this bug.