718232 - transition from maximized to full screen mode should hide toolbar before re-arranging it.

Status: NEW

(Firefox :: General, defect)

Description

[Asa Dotzler [:asa]]

Attachment: webm video of full-screen transition

When we transition to fullscreen mode, the first thing that happens is that we hide the "Firefox" menu and change the window controls to their smaller version. This causes the tabs all to slide left because the Firefox menu is gone. Then, after a very long pause, we animate the new toolbar up and off screen. 

This produces a very ugly and visually jarring transition. 

We should instead, first animate the toolbar up and off screen, and then, after it's off screen, immediately hide the Firefox button (if we think that's even useful) and switch out the windows controls. 

I've attached a webM video at quarter speed which lets you see how painful this transition is.

Comment 1

[Asa Dotzler [:asa]]

Not only would this remove some visual jank, but it could make the fullscreen conversion feel much faster and more responsive to the user so I'm making this a "snappy" bug.

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Tabs underneath button and Windows controls

How did you get your tabs to be part of the title bar like that?  Please see the attached image which shows how it looks for me with the tabs underneath the titlebar section.  Maybe I have a different setting than you or maybe something else changed since you posted this?

Comment 3

[Brian R. Bondy [:bbondy]]

I think maybe you're using https://addons.mozilla.org/en-US/firefox/addon/tabs-always-in-titlebar/ which introduces the visual jank.  Unless we make this the default look, maybe we should wontfix this bug.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Brian R. Bondy [:bbondy] from comment #2)
> How did you get your tabs to be part of the title bar like that?

It's a maximized window.

Comment 5

[Asa Dotzler [:asa]]

(In reply to Brian R. Bondy [:bbondy] from comment #3)
> I think maybe you're using
> https://addons.mozilla.org/en-US/firefox/addon/tabs-always-in-titlebar/
> which introduces the visual jank.  Unless we make this the default look,
> maybe we should wontfix this bug.

I'm not using any extensions. This is how a maximized Firefox window looks. The transition to fullscreen from maximized with zero add-ons and a purely default configuration (brand new profile) is janky.

Comment 6

[Brian R. Bondy [:bbondy]]

doh, Fail. Didn't realize it's different when maximized :S

Comment 7

[Brian R. Bondy [:bbondy]]

I haven't had a chance to look into this yet, but I briefly looked at the DOM inspector and code and here's what's going on...

There are 2 different toolbars:
1) Titlebar toolbar - which holds the Firefox button, and the large window controls (minimize, maximize, and close)
2) Tabs toolbar - Which holds the tabs and the sometimes visible small window controls (minimize, maximize, close) 

When you transition from normal window to maximized, the tabs go in the titlebar. 
When we transition to full screen we hide #1 and then slowly slide up #2.