Implement inline editing for renaming attachments when composing



Message Compose Window
6 years ago
2 years ago


(Reporter: squib, Unassigned)


Firefox Tracking Flags

(Not tracked)



(1 attachment)



6 years ago
+++ This bug was initially created as a clone of Bug #526998 +++

We should allow inline editing of attachment names in the compose window instead of opening a dialog box. I have a WIP patch for this, which I'll clean up and post sometime soon (hopefully).

Comment 1

5 years ago
Created attachment 648973 [details] [diff] [review]
WIP patch

How about this? It probably doesn't work quite right on anything but Linux, since I haven't given other themes the proper CSS, but that should be easy.
Attachment #648973 - Flags: ui-review?(bwinton)
Attachment #648973 - Flags: feedback?(mconley)
Comment on attachment 648973 [details] [diff] [review]
WIP patch

Only tested on Linux, but I'm loving it!  ui-r=me!

Attachment #648973 - Flags: ui-review?(bwinton) → ui-review+
Comment on attachment 648973 [details] [diff] [review]
WIP patch

Review of attachment 648973 [details] [diff] [review]:

This looks good to me.

What happens to Filelinks? I guess we can't really support renaming them once they're already uploaded? That'd mean a deletion and a re-upload if the storage API doesn't support renaming. :/

::: mail/base/content/mailWidgets.xml
@@ +484,5 @@
>        ]]></handler>
>      </handlers>
>    </binding>
> +  <binding id="attachmentitemediting" extends="chrome://messenger/content/mailWidgets.xml#attachmentitem">

attachmentitemediting is pretty hard to read. Can we use attachmentitem-editing instead?
Attachment #648973 - Flags: feedback?(mconley) → feedback+

Comment 4

4 years ago
Squib, can you finish this up?
Flags: needinfo?(squibblyflabbetydoo)

Comment 5

4 years ago
Shouldn't be too hard to finish up. I'll try to get to it before, say... December? Things have been getting ever-so-slightly less busy for me, so I'm hoping I can get some more of my WIP TB patches landed.
Flags: needinfo?(squibblyflabbetydoo)

Comment 6

2 years ago
Unassigning myself to let other folks work on this if they want.
Assignee: squibblyflabbetydoo → nobody
You need to log in before you can comment on or make changes to this bug.