718270 - Page zoomed in in this case, after dismissing vkb

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

I tested this on the LG Optimus Black in portrait mode.

Steps to reproduce:
- Visit testcase
- Tap on the input, vkb comes up
- Tap somewhere outside the input

Expected result:
- No change in zoom level on the page

Actual result:
- Page gets zoomed in quite far, for some reason

Comment 1

[Doug Turner (:dougt)]

kats, do you see this?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

On the Galaxy Tab I see it zoom in a little. I assume that since the optimus black has a smaller screen it will appear to zoom in farther. I can investigate this.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Note for prioritization: this will only happen if the page is smaller than the screen, which should rather infrequent.

Comment 4

[Martijn Wargers (dead)]

It happens for me on http://www.google.com .

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 6

[Patrick Walton (:pcwalton)]

Comment on attachment 591601 [details] [diff] [review]
Patch

Review of attachment 591601 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fe66d9bdc30

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8fe66d9bdc30

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 591601 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: page zooms in when vkb is hidden (on small pages)
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): mobile-only

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 591601 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/aae024495623

Comment 12

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 13.0a1 (2012-02-01)
                  Aurora  11.0a2 (2012-02-01)
Device: LG Optimus Black Android 2.2