Closed Bug 718278 Opened 13 years ago Closed 13 years ago

Remove chromedir attributes, use -moz-locale-dir instead

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Chromedir doesn't work anymore, we have to use -moz-locale-dir. I've found remnants in calendar-views.css and accountCentral.css
Exchange [chromedir="rtl"] with :-moz-locale-dir(rtl) Philipp do you give approval for beta? This doesn't work already under TB 9 and it would be good if this is fixed for the ESR release.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #588731 - Flags: review?(philipp)
Assignee: richard.marti → nobody
Product: Thunderbird → Calendar
QA Contact: general → general
Assignee: nobody → richard.marti
Comment on attachment 588731 [details] [diff] [review] use -moz-locale-dir sounds good, lets take this for beta. If you push this after Thursday, please ping me beforehand.
Attachment #588731 - Flags: review?(philipp)
Attachment #588731 - Flags: review+
Attachment #588731 - Flags: approval-mozilla-beta+
Attachment #588731 - Flags: approval-mozilla-aurora+
According to the original calendar bug 532102 all occurrences of chromedir="&locale.dir;" can be removed too.
Yes, this patch should fix every chromedir= occurence.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
I'm confused because the patch doesn't remove the |chromedir="&locale.dir;"| usage as indicated by comment 4 and comment 5. Are the entries still required in the *.xml and *.xul files or not?
I'm not sure but when I check <http://mxr.mozilla.org/comm-central/search?string=chromedir=> then also a lot of toolkit and mailnews files have still chromedir. Because of this I let them and changed only the css files.
(In reply to Richard Marti [:paenglab] from comment #8) > I'm not sure but when I check > <http://mxr.mozilla.org/comm-central/search?string=chromedir=> then also a > lot of toolkit and mailnews files have still chromedir. Because of this I > let them and changed only the css files. It does not make sense to have a chromedir attribute on elements if no CSS selector uses it afaik.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: