718278 - Remove chromedir attributes, use -moz-locale-dir instead

Status: RESOLVED FIXED

Description

[Richard Marti (:Paenglab)]

Chromedir doesn't work anymore, we have to use -moz-locale-dir.

I've found remnants in calendar-views.css and accountCentral.css

Comment 1

[Richard Marti (:Paenglab)]

Attachment: use -moz-locale-dir

Exchange [chromedir="rtl"] with :-moz-locale-dir(rtl)

Philipp do you give approval for beta? This doesn't work already under TB 9 and it would be good if this is fixed for the ESR release.

Comment 2

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 588731 [details] [diff] [review]
use -moz-locale-dir

sounds good, lets take this for beta. If you push this after Thursday, please ping me beforehand.

Comment 4

[Stefan Sitter [:ssitter]]

According to the original calendar bug 532102 all occurrences of chromedir="&locale.dir;" can be removed too.

Comment 5

[Richard Marti (:Paenglab)]

Yes, this patch should fix every chromedir= occurence.

Comment 6

[Richard Marti (:Paenglab)]

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/8bdd5d2f7ece>
and to comm-aurora: <http://hg.mozilla.org/releases/comm-aurora/rev/f5cf00dfa02f>
and to comm-beta: <http://hg.mozilla.org/releases/comm-beta/rev/00948fc038f1>

Comment 7

[Stefan Sitter [:ssitter]]

I'm confused because the patch doesn't remove the |chromedir="&locale.dir;"| usage as indicated by comment 4 and comment 5. Are the entries still required in the *.xml and *.xul files or not?

Comment 8

[Richard Marti (:Paenglab)]

I'm not sure but when I check <http://mxr.mozilla.org/comm-central/search?string=chromedir=> then also a lot of toolkit and mailnews files have still chromedir. Because of this I let them and changed only the css files.

Comment 9

[Martin Schröder [:martinschroeder]]

(In reply to Richard Marti [:paenglab] from comment #8)
> I'm not sure but when I check
> <http://mxr.mozilla.org/comm-central/search?string=chromedir=> then also a
> lot of toolkit and mailnews files have still chromedir. Because of this I
> let them and changed only the css files.

It does not make sense to have a chromedir attribute on elements if no CSS selector uses it afaik.