The default bug view has changed. See this FAQ.

Add more sampler labels to various places

RESOLVED FIXED in mozilla12

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla12
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 588899 [details] [diff] [review]
Some more labels
Attachment #588899 - Flags: review?
(Assignee)

Comment 2

5 years ago
Created attachment 588901 [details] [diff] [review]
labels around network io
Attachment #588901 - Flags: review?
(Assignee)

Comment 3

5 years ago
Created attachment 588903 [details] [diff] [review]
Labels for debugging the github problem
Attachment #588903 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #588899 - Flags: review? → review?(bgirard)
(Assignee)

Updated

5 years ago
Attachment #588901 - Flags: review? → review?(bgirard)
(Assignee)

Updated

5 years ago
Attachment #588903 - Flags: review? → review?(bgirard)
Comment on attachment 588903 [details] [diff] [review]
Labels for debugging the github problem

Review of attachment 588903 [details] [diff] [review]:
-----------------------------------------------------------------

The patches looks good. It doesn't look like we're adding sampling to any performance critical code. I can r+ the cocoa changes but maybe we need someone else to review a patch that touch other modules. They just need to 'ok' adding a few cycles to these functions.

::: tools/profiler/sampler.h
@@ +106,4 @@
>  #define SAMPLER_GET_RESPONSIVENESS() NULL
>  #define SAMPLER_GET_FEATURES() NULL
>  #define SAMPLE_LABEL(name_space, info)
> +#define SAMPLE_LABEL_FN(name_space, info)

We should just pick a single standard and use it everywhere for all 3 patches. I think I would vote for that to be:
SAMPLE_LABEL_FN

The info parameter here isn't needed.

Do you think PRETTY_FUNCTION is to verbose? Maybe using __func__ is enough. To be honest I think PRETTY_FUNCTION is too verbose because it include parameters and return type, and that __func__ is ambiguous because it doesn't include namespace.
(Assignee)

Comment 5

5 years ago
Created attachment 589273 [details] [diff] [review]
All in one patch

This also gets rid of the function macros because they don't provide what we want.

The naming is still pretty adhoc throughout as I'm not really sure what a good convention should be. I think we can figure that out as we add more labels and use them more.
Attachment #588899 - Attachment is obsolete: true
Attachment #588901 - Attachment is obsolete: true
Attachment #588903 - Attachment is obsolete: true
Attachment #588899 - Flags: review?(bgirard)
Attachment #588901 - Flags: review?(bgirard)
Attachment #588903 - Flags: review?(bgirard)
Attachment #589273 - Flags: review?(bgirard)

Updated

5 years ago
Attachment #589273 - Flags: review?(bgirard) → review+
Landed on inbound, but backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88733ce1bef3
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebc05c90d282

because of errors building nsLayoutModule.obj on Windows:
https://tbpl.mozilla.org/php/getParsedLog.php?id=8618482&tree=Mozilla-Inbound
Assignee: nobody → jmuizelaar
https://hg.mozilla.org/mozilla-central/rev/88733ce1bef3
https://hg.mozilla.org/mozilla-central/rev/ebc05c90d282
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/147c00d2ca3b

Please comment in bugs when they land on inbound, especially if they've been backed out and/or re-landed.  It takes some of the pain out of merging.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.